-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Added alerts page #190751
Merged
shahzad31
merged 9 commits into
elastic:main
from
dominiqueclarke:feat/synthetics-alerts-page
Aug 20, 2024
Merged
[Synthetics] Added alerts page #190751
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
85a801b
added alerts page
shahzad31 a8efed7
Update x-pack/plugins/observability_solution/synthetics/public/apps/s…
dominiqueclarke cfb2afa
Merge branch 'main' of https://github.com/elastic/kibana into feat/sy…
shahzad31 597c3bc
update test
shahzad31 3755eee
update test
shahzad31 868367f
added date picker
shahzad31 8b6e3b7
show one refresh button
shahzad31 dd45c6e
update consumers
shahzad31 63afd08
update consumers
shahzad31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
...hetics/public/apps/synthetics/components/monitor_details/hooks/use_fetch_active_alerts.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { BASE_RAC_ALERTS_API_PATH } from '@kbn/rule-registry-plugin/common'; | ||
| import { AlertConsumers } from '@kbn/rule-registry-plugin/common/technical_rule_data_field_names'; | ||
| import { useFetcher } from '@kbn/observability-shared-plugin/public'; | ||
| import { useKibana } from '@kbn/kibana-react-plugin/public'; | ||
| import { useParams } from 'react-router-dom'; | ||
| import type { ESSearchResponse } from '@kbn/es-types'; | ||
| import { useSelectedLocation } from './use_selected_location'; | ||
|
|
||
| import { ClientPluginsStart } from '../../../../../plugin'; | ||
|
|
||
| export function useFetchActiveAlerts() { | ||
| const { http } = useKibana<ClientPluginsStart>().services; | ||
|
|
||
| const { monitorId: configId } = useParams<{ monitorId: string }>(); | ||
|
|
||
| const selectedLocation = useSelectedLocation(); | ||
|
|
||
| const { loading, data } = useFetcher(async () => { | ||
| return await http.post<ESSearchResponse>(`${BASE_RAC_ALERTS_API_PATH}/find`, { | ||
| body: JSON.stringify({ | ||
| feature_ids: [AlertConsumers.UPTIME, AlertConsumers.OBSERVABILITY], | ||
| size: 0, | ||
| track_total_hits: true, | ||
| query: { | ||
| bool: { | ||
| filter: [ | ||
| { | ||
| range: { | ||
| '@timestamp': { | ||
| gte: 'now-24h/h', | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| term: { | ||
| configId, | ||
| }, | ||
| }, | ||
| { | ||
| term: { | ||
| 'location.id': selectedLocation?.id, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| }), | ||
| }); | ||
| }, [configId, http, selectedLocation?.id]); | ||
|
|
||
| return { | ||
| loading, | ||
| data, | ||
| numberOfAlerts: data?.hits?.total.value ?? 0, | ||
| }; | ||
| } |
15 changes: 15 additions & 0 deletions
15
...nthetics/public/apps/synthetics/components/monitor_details/monitor_alerts/alerts_icon.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
| import React from 'react'; | ||
| import { EuiBadge } from '@elastic/eui'; | ||
| import { useFetchActiveAlerts } from '../hooks/use_fetch_active_alerts'; | ||
|
|
||
| export const MonitorAlertsIcon = () => { | ||
| const { numberOfAlerts } = useFetchActiveAlerts(); | ||
|
|
||
| return numberOfAlerts > 0 ? <EuiBadge color="danger">{numberOfAlerts}</EuiBadge> : null; | ||
| }; |
65 changes: 65 additions & 0 deletions
65
...ublic/apps/synthetics/components/monitor_details/monitor_alerts/monitor_detail_alerts.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
| import { EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiLoadingSpinner } from '@elastic/eui'; | ||
| import React from 'react'; | ||
| import { AlertConsumers } from '@kbn/rule-data-utils'; | ||
| import { useKibana } from '@kbn/kibana-react-plugin/public'; | ||
| import { useParams } from 'react-router-dom'; | ||
| import { useRefreshedRangeFromUrl } from '../../../hooks'; | ||
| import { SyntheticsDatePicker } from '../../common/date_picker/synthetics_date_picker'; | ||
| import { useSelectedLocation } from '../hooks/use_selected_location'; | ||
| import { ClientPluginsStart } from '../../../../../plugin'; | ||
|
|
||
| export const MONITOR_ALERTS_TABLE_ID = 'xpack.observability.slo.sloDetails.alertTable'; | ||
|
|
||
| export function MonitorDetailsAlerts() { | ||
| const { | ||
| triggersActionsUi: { alertsTableConfigurationRegistry, getAlertsStateTable: AlertsStateTable }, | ||
| observability: { observabilityRuleTypeRegistry }, | ||
| } = useKibana<ClientPluginsStart>().services; | ||
|
|
||
| const { monitorId: configId } = useParams<{ monitorId: string }>(); | ||
|
|
||
| const selectedLocation = useSelectedLocation(); | ||
| const { from, to } = useRefreshedRangeFromUrl(); | ||
|
|
||
| if (!selectedLocation) { | ||
| return <EuiLoadingSpinner size="xl" />; | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <EuiSpacer size="m" /> | ||
| <EuiFlexGroup direction="column" gutterSize="xl"> | ||
| <EuiFlexItem> | ||
| <SyntheticsDatePicker fullWidth={true} /> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem> | ||
| <AlertsStateTable | ||
| alertsTableConfigurationRegistry={alertsTableConfigurationRegistry} | ||
| configurationId={AlertConsumers.OBSERVABILITY} | ||
| id={MONITOR_ALERTS_TABLE_ID} | ||
| data-test-subj="monitorAlertsTable" | ||
| featureIds={[AlertConsumers.UPTIME, AlertConsumers.OBSERVABILITY]} | ||
| query={{ | ||
| bool: { | ||
| filter: [ | ||
| { term: { configId } }, | ||
| { term: { 'location.id': selectedLocation?.id } }, | ||
| { range: { '@timestamp': { gte: from, lte: to } } }, | ||
| ], | ||
| }, | ||
| }} | ||
| showAlertStatusWithFlapping | ||
| initialPageSize={100} | ||
| cellContext={{ observabilityRuleTypeRegistry }} | ||
| /> | ||
| </EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| </> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to pass
AlertConsumers.OBSERVABILITYfeatured here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/slo/public/hooks/use_fetch_active_alerts.ts#L58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not needed, will remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to update here, we had a discussion in Slack and this might be needed for Serverless, needs to be verified.