[Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting #194947

janmonschke · 2024-10-04T13:33:02Z

Summary

Fixes: #193097

Adds a new Kibana advanced setting that allows users to limit the maximum amount of unassociated notes. The max value for that used to be hard coded before.

Screen.Recording.2024-10-09.at.10.58.29.mov

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…ithub.com/janmonschke/kibana into securitySolution/noteLimitAdvancedSetting

elasticmachine · 2024-10-09T13:38:37Z

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

…ithub.com/janmonschke/kibana into securitySolution/noteLimitAdvancedSetting

PhilippeOberti

Reviewing this PR made me realize that I hadn't really understood well why we're doing this MAX_UNASSOCIATED_NOTES thing...

Take this example:

I'm setting a limit to 1 in the Advanced Settings
I'm creating a note in the flyout for a document only => it works
I'm trying to create a second note => it fails
I create a timeline, save it, then try to create a second note for the same document => it works

Screen.Recording.2024-10-10.at.5.03.32.PM.mov

I had a long discussion with Kevin on Slack and I'm now really confused about what we're trying to achieve here 😆

PhilippeOberti · 2024-10-10T21:53:32Z

x-pack/plugins/security_solution/public/notes/components/add_note.tsx

@@ -101,14 +102,19 @@ export const AddNote = memo(
      setEditorValue('');
    }, [dispatch, editorValue, eventId, telemetry, timelineId, onNoteAdd]);

+    const resetError = useCallback(() => {


currently if the user tries to close the error toast using the cross icon in the top-right corner nothing happens. You're forced to click on the See the full error button that opens the modal then it clears

Screen.Recording.2024-10-10.at.4.35.21.PM.mov

this is now fixed, thanks!

x-pack/plugins/security_solution/public/notes/store/notes.slice.ts

PhilippeOberti · 2024-10-10T21:59:08Z

x-pack/plugins/security_solution/server/ui_settings.ts

+    [MAX_UNASSOCIATED_NOTES]: {
+      name: i18n.translate('xpack.securitySolution.uiSettings.maxUnassociatedNotesLabel', {
+        defaultMessage: 'Maximum amount of unassociated notes',
+      }),
+      description: i18n.translate(
+        'xpack.securitySolution.uiSettings.maxUnassociatedNotesDescription',
+        {
+          defaultMessage:
+            'Defines the maximum amount of unassociated notes (notes that are not assigned to a timeline) that can be created.',
+        }
+      ),
+      type: 'number',
+      value: DEFAULT_MAX_UNASSOCIATED_NOTES,
+      schema: schema.number({
+        min: 1,
+        max: 1000,
+        defaultValue: DEFAULT_MAX_UNASSOCIATED_NOTES,
+      }),
+      requiresPageReload: false,
+    },


I think we need to rethink the term unassociated notes because it doesn't really mean anything. Seeing this in the Advanced Settings I was like what is an unassociated note? It's specified in parenthesis that these are notes not associated with a timeline, but users will wonder what's the difference and why we're doing this...

I'm happy to change the wording to something more suitable if you have ideas :)

I will start a discussion with Nastasha about this, we don't have to wait to merge this PR!

Same here.. I don't get the meaning of this setting. Does this mean that when notes are assigned to timeline then i can go above MAX_UNASSOCIATED_NOTES but if they are not then I have to stay within the limits?

yes, the maximum number of notes only applies to what we call unassociated notes (which is not a good name by the way, we should change that in the future), which are notes associated to only a document

PhilippeOberti · 2024-10-10T22:36:24Z

Reviewing this PR made me realize that I hadn't really understood well why we're doing this MAX_UNASSOCIATED_NOTES thing...

Take this example:

I'm setting a limit to 1 in the Advanced Settings

I'm creating a note in the flyout for a document only => it works

I'm trying to create a second note => it fails

I create a timeline, save it, then try to create a second note for the same document => it works

I had a long discussion with Kevin on Slack and I'm now really confused about what we're trying to achieve here 😆

After more discussion I understand a bit more why we're doing this. We want to limit the number of notes that are only associated with a document because the notes associated with a timeline will be automatically deleted when the timeline is deleted.
I still feel something in the UI feels off, because we're basically telling the user: hey you have reached the quota and cannot create any new notes, unless you use this hack and associate the new notes with a timeline 😆

As a user, I would just create an empty timeline, save it, then continue create a bunch of new notes associating them with that dummy timeline...
Maybe the only change here is to NOT explicitly tell the user how to get around the limit?

I'll keep thinking about it!

PhilippeOberti

While there are some texts that could be changed/improved, this PR does the expected functionality. Thanks for implementing this!

I will get with @nastasha-solomon for copy changes as we have to review all the notes stuff together.

PhilippeOberti · 2024-10-11T21:33:58Z

x-pack/plugins/security_solution/server/ui_settings.ts

+    [MAX_UNASSOCIATED_NOTES]: {
+      name: i18n.translate('xpack.securitySolution.uiSettings.maxUnassociatedNotesLabel', {
+        defaultMessage: 'Maximum amount of unassociated notes',
+      }),
+      description: i18n.translate(
+        'xpack.securitySolution.uiSettings.maxUnassociatedNotesDescription',
+        {
+          defaultMessage:
+            'Defines the maximum amount of unassociated notes (notes that are not assigned to a timeline) that can be created.',
+        }
+      ),
+      type: 'number',
+      value: DEFAULT_MAX_UNASSOCIATED_NOTES,
+      schema: schema.number({
+        min: 1,
+        max: 1000,
+        defaultValue: DEFAULT_MAX_UNASSOCIATED_NOTES,
+      }),
+      requiresPageReload: false,
+    },


I will start a discussion with Nastasha about this, we don't have to wait to merge this PR!

x-pack/plugins/security_solution/public/notes/store/notes.slice.ts

PhilippeOberti · 2024-10-11T21:35:24Z

x-pack/plugins/security_solution/public/notes/components/add_note.tsx

@@ -101,14 +102,19 @@ export const AddNote = memo(
      setEditorValue('');
    }, [dispatch, editorValue, eventId, telemetry, timelineId, onNoteAdd]);

+    const resetError = useCallback(() => {


this is now fixed, thanks!

logeekal

Did Desk testing and things seems to be working well. Before I approve I do have some questions.

~~Is this limit only for the notes associated to the events and not timeline? If yes, Why?~~ ( Answered in Philiipe's other comment )
Is this a global limit. Does this mean, that if i have MAX notes associated to a single event, i cannot add any more notes to any other event ?
Also, even though I cannot add any more notes to any other event, we can add more notes to the timeline?

Additionally, I have left some comments regarding the code review. They are not PR blockers, just minor comments.

logeekal · 2024-10-14T08:10:24Z

x-pack/plugins/security_solution/common/constants.ts

@@ -199,6 +200,9 @@ export const ENABLE_ASSET_CRITICALITY_SETTING = 'securitySolution:enableAssetCri
 export const EXCLUDED_DATA_TIERS_FOR_RULE_EXECUTION =
  'securitySolution:excludedDataTiersForRuleExecution' as const;

+/** This Kibana Advances setting allows users to define the maximum amount of unassociated notes (notes without a `timelineId`) */
+export const MAX_UNASSOCIATED_NOTES = 'securitySolution:maxUnassociatedNotes' as const;


Consider renaming this to something as below because current name feels like it is the number of MAX_NOTES but not the setting name.

Suggested change

export const MAX_UNASSOCIATED_NOTES = 'securitySolution:maxUnassociatedNotes' as const;

export const MAX_UNASSOCIATED_NOTES_SETTING = 'securitySolution:maxUnassociatedNotes' as const;

logeekal · 2024-10-14T08:20:27Z

x-pack/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts

@@ -48,7 +52,7 @@ export const getNotesRoute = (router: SecuritySolutionPluginRouter) => {
                type: noteSavedObjectType,
                search: docIdSearchString,
                page: 1,
-                perPage: MAX_UNASSOCIATED_NOTES,
+                perPage: maxUnassociatedNotes,


I know this was not the scope of this PR and should have been done when original code was added but i do not see any e2e or proper integration test for this API. I only see unit tests for this feature where almost everything seems to be mocked. Honestly, in my opinion that does not give too much confidence. Let me know what you think.

If possible, consider adding api integration tests in x-pack/test/security_solution_api_integration/

logeekal · 2024-10-14T08:22:23Z

x-pack/plugins/security_solution/public/notes/api/api.ts

+    if (noteResponse.code !== 200) {
+      throw new Error(noteResponse.message);
+    }
+    return noteResponse.note;


Consider adding unit tests for this case.

logeekal · 2024-10-14T08:24:18Z

x-pack/plugins/security_solution/public/notes/api/api.ts

  return response;
 };

 /**
 * Deletes multiple notes
 */
 export const deleteNotes = async (noteIds: string[]) => {
-  const response = await KibanaServices.get().http.delete<{ data: unknown }>(NOTE_URL, {
+  const response = await KibanaServices.get().http.delete<DeleteNoteResponse>(NOTE_URL, {


👌 on adding all the types.

logeekal · 2024-10-14T08:33:23Z

x-pack/plugins/security_solution/server/ui_settings.ts

+    [MAX_UNASSOCIATED_NOTES]: {
+      name: i18n.translate('xpack.securitySolution.uiSettings.maxUnassociatedNotesLabel', {
+        defaultMessage: 'Maximum amount of unassociated notes',
+      }),
+      description: i18n.translate(
+        'xpack.securitySolution.uiSettings.maxUnassociatedNotesDescription',
+        {
+          defaultMessage:
+            'Defines the maximum amount of unassociated notes (notes that are not assigned to a timeline) that can be created.',
+        }
+      ),
+      type: 'number',
+      value: DEFAULT_MAX_UNASSOCIATED_NOTES,
+      schema: schema.number({
+        min: 1,
+        max: 1000,
+        defaultValue: DEFAULT_MAX_UNASSOCIATED_NOTES,
+      }),
+      requiresPageReload: false,
+    },


Same here.. I don't get the meaning of this setting. Does this mean that when notes are assigned to timeline then i can go above MAX_UNASSOCIATED_NOTES but if they are not then I have to stay within the limits?

logeekal · 2024-10-14T08:58:39Z

After more discussion I understand a bit more why we're doing this. We want to limit the number of notes that are only associated with a document because the notes associated with a timeline will be automatically deleted when the timeline is deleted.

Thanks @PhilippeOberti , I had same confustion. This clears it up. Do you think we should give a Toast confirming that note is associated to the timeline. Also add a warning on the Timeline's Notes tab that Notes will be deleted when timeline is deleted?

Question

Additionally I have one more question. Why the note add from Notes tab is not visible in Flyout but note added from Flyout is, even though both are attached to the timeline

timeline_event_notes_limit_confusion.mp4

kibanamachine · 2024-10-14T17:14:30Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11332124818

…bana setting (elastic#194947) ## Summary Fixes: elastic#193097 Adds a new Kibana advanced setting that allows users to limit the maximum amount of unassociated notes. The max value for that used to be hard coded before. https://github.com/user-attachments/assets/34af7f67-9109-4251-a5a3-a1af68f123fe ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 925329e)

kibanamachine · 2024-10-14T17:19:22Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ced Kibana setting (#194947) (#196192) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting (#194947)](#194947)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Jan Monschke <jan.monschke@elastic.co>

@nastasha-solomon

…e the unassociated note advanced setting under the Security Solution section (#197312) ## Summary This PR tackles 2 small tasks: - move the unassociated advanced settings introduced in [this PR](#194947) under the `Security Solution` category instead of `General` - make some copy changes on the notes functionality, mainly the following ([copy changes document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84)) - make sure we don't use a capital `N` for the word `note` - make sure that we use a capital `T` for the word `timeline` - change some of the no message and callout texts - prioritize using `attach` instead of `associate` All changes have been done with @nastasha-solomon. #193495

@nastasha-solomon

…e the unassociated note advanced setting under the Security Solution section (elastic#197312) ## Summary This PR tackles 2 small tasks: - move the unassociated advanced settings introduced in [this PR](elastic#194947) under the `Security Solution` category instead of `General` - make some copy changes on the notes functionality, mainly the following ([copy changes document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84)) - make sure we don't use a capital `N` for the word `note` - make sure that we use a capital `T` for the word `timeline` - change some of the no message and callout texts - prioritize using `attach` instead of `associate` All changes have been done with @nastasha-solomon. elastic#193495 (cherry picked from commit 800e392)

@nastasha-solomon

…e the unassociated note advanced setting under the Security Solution section (elastic#197312) ## Summary This PR tackles 2 small tasks: - move the unassociated advanced settings introduced in [this PR](elastic#194947) under the `Security Solution` category instead of `General` - make some copy changes on the notes functionality, mainly the following ([copy changes document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84)) - make sure we don't use a capital `N` for the word `note` - make sure that we use a capital `T` for the word `timeline` - change some of the no message and callout texts - prioritize using `attach` instead of `associate` All changes have been done with @nastasha-solomon. elastic#193495 (cherry picked from commit 800e392)

@nastasha-solomon

…e + move the unassociated note advanced setting under the Security Solution section (#197312) (#197350) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)](#197312)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>

@nastasha-solomon

… + move the unassociated note advanced setting under the Security Solution section (#197312) (#197351) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)](#197312)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>

…tes advanced setting to be 10k instead of 1k (#212786) ## Summary This previous [PR](#194947) made the maximum number of unassociated notes an advanced settings so that user can change the value within a certain limit. The intent was to allow that value to be between 1 and 10,000 (see acceptance criteria of the [original ticket](#193097)) but we missed one 0 and the maximum value allowed got set to 1000. This PR fixes that. #### Before ![Screenshot 2025-02-28 at 9 18 14 AM](https://github.com/user-attachments/assets/cf1d473c-5bd5-4759-a834-60888b0c8f78) #### After ![Screenshot 2025-02-28 at 9 18 47 AM](https://github.com/user-attachments/assets/129ba898-bbad-420a-b615-b0a456640af4)

…tes advanced setting to be 10k instead of 1k (elastic#212786) ## Summary This previous [PR](elastic#194947) made the maximum number of unassociated notes an advanced settings so that user can change the value within a certain limit. The intent was to allow that value to be between 1 and 10,000 (see acceptance criteria of the [original ticket](elastic#193097)) but we missed one 0 and the maximum value allowed got set to 1000. This PR fixes that. #### Before ![Screenshot 2025-02-28 at 9 18 14 AM](https://github.com/user-attachments/assets/cf1d473c-5bd5-4759-a834-60888b0c8f78) #### After ![Screenshot 2025-02-28 at 9 18 47 AM](https://github.com/user-attachments/assets/129ba898-bbad-420a-b615-b0a456640af4) (cherry picked from commit eabf95d)

…ated notes advanced setting to be 10k instead of 1k (#212786) (#212823) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)](#212786)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>

…ted notes advanced setting to be 10k instead of 1k (#212786) (#212825) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)](#212786)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>

…ated notes advanced setting to be 10k instead of 1k (#212786) (#212822) # Backport This will backport the following commits from `main` to `8.17`: - [[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)](#212786)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>

…ted notes advanced setting to be 10k instead of 1k (#212786) (#212824) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)](#212786)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>

…tes advanced setting to be 10k instead of 1k (elastic#212786) ## Summary This previous [PR](elastic#194947) made the maximum number of unassociated notes an advanced settings so that user can change the value within a certain limit. The intent was to allow that value to be between 1 and 10,000 (see acceptance criteria of the [original ticket](elastic#193097)) but we missed one 0 and the maximum value allowed got set to 1000. This PR fixes that. #### Before ![Screenshot 2025-02-28 at 9 18 14 AM](https://github.com/user-attachments/assets/cf1d473c-5bd5-4759-a834-60888b0c8f78) #### After ![Screenshot 2025-02-28 at 9 18 47 AM](https://github.com/user-attachments/assets/129ba898-bbad-420a-b615-b0a456640af4) (cherry picked from commit eabf95d)

…ated notes advanced setting to be 10k instead of 1k (#212786) (#212930) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)](#212786)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

…ted notes advanced setting to be 10k instead of 1k (elastic#212786) (elastic#212824) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (elastic#212786)](elastic#212786)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>

make MAX_UNASSOCIATED_NOTES an advanced Kibana setting

8d47035

janmonschke added release_note:enhancement Team:Threat Hunting:Investigations Security Solution Investigations Team backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Oct 4, 2024

janmonschke and others added 4 commits October 4, 2024 15:53

update generated telemetry files

efb7ffe

Merge branch 'main' into securitySolution/noteLimitAdvancedSetting

f26fce3

Merge branch 'main' into securitySolution/noteLimitAdvancedSetting

d4cd1cf

reset note error when toast gets closed

9e64bd4

janmonschke changed the title ~~[IN PROGRESS][Security Solution] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting~~ [Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting Oct 9, 2024

elasticmachine and others added 3 commits October 9, 2024 13:17

Merge branch 'main' into securitySolution/noteLimitAdvancedSetting

6e06ae5

Merge branch 'securitySolution/noteLimitAdvancedSetting' of https://g…

07c7223

…ithub.com/janmonschke/kibana into securitySolution/noteLimitAdvancedSetting

Merge branch 'main' into securitySolution/noteLimitAdvancedSetting

46bd9a7

janmonschke marked this pull request as ready for review October 9, 2024 13:38

janmonschke requested review from a team as code owners October 9, 2024 13:38

janmonschke added 3 commits October 9, 2024 15:49

fix test

52de3b8

Merge branch 'securitySolution/noteLimitAdvancedSetting' of https://g…

d6ba97a

…ithub.com/janmonschke/kibana into securitySolution/noteLimitAdvancedSetting

fix test

3fa05f8

elastic deleted a comment from kibana-ci Oct 10, 2024

PhilippeOberti reviewed Oct 10, 2024

View reviewed changes

janmonschke added 3 commits October 11, 2024 06:16

fix unresponsive close behaviour

b0a0e3f

remove now-unused onClose

9919cb9

remove another warning

c4a8eb5

PhilippeOberti approved these changes Oct 11, 2024

View reviewed changes

logeekal reviewed Oct 14, 2024

View reviewed changes

kibanamachine added the v9.0.0 label Oct 14, 2024

kibanamachine mentioned this pull request Oct 14, 2024

[8.x] [Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting (#194947) #196192

Merged

kibanamachine added the v8.16.0 label Oct 14, 2024

nastasha-solomon mentioned this pull request Oct 21, 2024

[Request][Serverless][8.16] New notes experience elastic/security-docs#5441

Closed

23 tasks

PhilippeOberti mentioned this pull request Oct 22, 2024

[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section #197312

Merged

2 tasks

This was referenced Feb 27, 2025

[Security Solution][Notes] update logic for notes for documents maximum limit #212687

Open

[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k #212786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting #194947

[Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting #194947

janmonschke commented Oct 4, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Oct 9, 2024

PhilippeOberti left a comment

PhilippeOberti Oct 10, 2024

PhilippeOberti Oct 11, 2024

PhilippeOberti Oct 10, 2024

janmonschke Oct 11, 2024

PhilippeOberti Oct 11, 2024

logeekal Oct 14, 2024

PhilippeOberti Oct 14, 2024

PhilippeOberti commented Oct 10, 2024

PhilippeOberti left a comment

PhilippeOberti Oct 11, 2024

PhilippeOberti Oct 11, 2024

logeekal left a comment •

edited

Loading

logeekal Oct 14, 2024

logeekal Oct 14, 2024

logeekal Oct 14, 2024

logeekal Oct 14, 2024

logeekal Oct 14, 2024

logeekal commented Oct 14, 2024

kibanamachine commented Oct 14, 2024

kibanamachine commented Oct 14, 2024

	export const MAX_UNASSOCIATED_NOTES = 'securitySolution:maxUnassociatedNotes' as const;
	export const MAX_UNASSOCIATED_NOTES_SETTING = 'securitySolution:maxUnassociatedNotes' as const;

[Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting #194947

[Security Solution][Notes] Make MAX_UNASSOCIATED_NOTES an advanced Kibana setting #194947

Conversation

janmonschke commented Oct 4, 2024 • edited by kibanamachine Loading

Summary

Checklist

elasticmachine commented Oct 9, 2024

PhilippeOberti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PhilippeOberti commented Oct 10, 2024

PhilippeOberti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

logeekal left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

logeekal commented Oct 14, 2024

Question

kibanamachine commented Oct 14, 2024

kibanamachine commented Oct 14, 2024

💚 All backports created successfully

Questions ?

janmonschke commented Oct 4, 2024 •

edited by kibanamachine

Loading

logeekal left a comment •

edited

Loading