Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Preconfigured Endpoint Names #197498

Conversation

Samiul-TheSoccerFan
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan commented Oct 23, 2024

Summary

Updates the preconfigured names as backend changes are merged.

Screenshot 2024-10-23 at 12 15 18 PM

Checklist

@Samiul-TheSoccerFan Samiul-TheSoccerFan added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Search v8.16.0 backport:version Backport to applied version labels labels Oct 23, 2024
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested a review from a team as a code owner October 23, 2024 16:32
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested a review from a team October 23, 2024 16:32
@Samiul-TheSoccerFan Samiul-TheSoccerFan enabled auto-merge (squash) October 23, 2024 16:33
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchInferenceEndpoints 77.5KB 77.5KB +35.0B

Copy link
Member

@saarikabhasi saarikabhasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code only review

@Samiul-TheSoccerFan Samiul-TheSoccerFan merged commit 658ecea into elastic:main Oct 23, 2024
40 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11486824657

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2024
## Summary

Updates the preconfigured names as backend changes are merged.

![Screenshot 2024-10-23 at 12 15
18 PM](https://github.com/user-attachments/assets/1cec2662-8176-4262-883c-759ae50d8106)

### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 658ecea)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16
8.x Backport failed because of merge conflicts

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 197498

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 23, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [Update Preconfigured Endpoint Names
(#197498)](#197498)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Samiul
Monir","email":"150824886+Samiul-TheSoccerFan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-23T19:29:17Z","message":"Update
Preconfigured Endpoint Names (#197498)\n\n## Summary\r\n\r\nUpdates the
preconfigured names as backend changes are merged.\r\n\r\n![Screenshot
2024-10-23 at 12
15\r\n18 PM](https://github.com/user-attachments/assets/1cec2662-8176-4262-883c-759ae50d8106)\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"658ecea7874f2f84d26f3f29fdc5a49125f70313","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","v8.16.0","backport:version","v8.17.0"],"title":"Update
Preconfigured Endpoint
Names","number":197498,"url":"https://github.com/elastic/kibana/pull/197498","mergeCommit":{"message":"Update
Preconfigured Endpoint Names (#197498)\n\n## Summary\r\n\r\nUpdates the
preconfigured names as backend changes are merged.\r\n\r\n![Screenshot
2024-10-23 at 12
15\r\n18 PM](https://github.com/user-attachments/assets/1cec2662-8176-4262-883c-759ae50d8106)\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"658ecea7874f2f84d26f3f29fdc5a49125f70313"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197498","number":197498,"mergeCommit":{"message":"Update
Preconfigured Endpoint Names (#197498)\n\n## Summary\r\n\r\nUpdates the
preconfigured names as backend changes are merged.\r\n\r\n![Screenshot
2024-10-23 at 12
15\r\n18 PM](https://github.com/user-attachments/assets/1cec2662-8176-4262-883c-759ae50d8106)\r\n\r\n\r\n###
Checklist\r\n\r\n\r\n- [X] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"658ecea7874f2f84d26f3f29fdc5a49125f70313"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Samiul Monir <150824886+Samiul-TheSoccerFan@users.noreply.github.com>
@Samiul-TheSoccerFan
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Oct 24, 2024
## Summary

Updates the preconfigured names as backend changes are merged.

![Screenshot 2024-10-23 at 12 15
18 PM](https://github.com/user-attachments/assets/1cec2662-8176-4262-883c-759ae50d8106)

### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 658ecea)

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/constants.ts
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_actions/actions/delete/delete_action.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/tabular_page.test.tsx
Samiul-TheSoccerFan added a commit that referenced this pull request Oct 25, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Update Preconfigured Endpoint Names
(#197498)](#197498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants