Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Preconfigured Endpoint Names #197498

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update Preconfigured Endpoint Names #197498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc79e26
updating default endpoints name
Samiul-TheSoccerFan Oct 23, 2024
1fd63eb
fixing tests
Samiul-TheSoccerFan Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...plugins/search_inference_endpoints/public/components/all_inference_endpoints/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ export const DEFAULT_INFERENCE_ENDPOINTS_TABLE_STATE: AllInferenceEndpointsTable
export const PIPELINE_URL = 'ingest/ingest_pipelines';

export const PRECONFIGURED_ENDPOINTS = {
ELSER: '.elser-2',
E5: '.multi-e5-small',
ELSER: '.elser-2-elasticsearch',
E5: '.multilingual-e5-small-elasticsearch',
};
2 changes: 1 addition & 1 deletion ...rence_endpoints/render_table_columns/render_actions/actions/delete/delete_action.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('Delete Action', () => {
});

it('disable the delete action for preconfigured endpoint', () => {
const preconfiguredMockItem = { ...mockItem, endpoint: '.elser-2' };
const preconfiguredMockItem = { ...mockItem, endpoint: '.multilingual-e5-small-elasticsearch' };
render(<Wrapper item={preconfiguredMockItem} />);

expect(screen.getByTestId('inferenceUIDeleteAction')).toBeDisabled();
Expand Down
8 changes: 4 additions & 4 deletions ...earch_inference_endpoints/public/components/all_inference_endpoints/tabular_page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const inferenceEndpoints = [
task_settings: {},
},
{
inference_id: '.elser-2',
inference_id: '.elser-2-elasticsearch',
task_type: 'sparse_embedding',
service: 'elasticsearch',
service_settings: {
Expand All @@ -57,7 +57,7 @@ const inferenceEndpoints = [
task_settings: {},
},
{
inference_id: '.multi-e5-small',
inference_id: '.multilingual-e5-small-elasticsearch',
task_type: 'text_embedding',
service: 'elasticsearch',
service_settings: {
Expand All @@ -80,8 +80,8 @@ describe('When the tabular page is loaded', () => {
render(<TabularPage inferenceEndpoints={inferenceEndpoints} />);

const rows = screen.getAllByRole('row');
expect(rows[1]).toHaveTextContent('.elser-2');
expect(rows[2]).toHaveTextContent('.multi-e5-small');
expect(rows[1]).toHaveTextContent('.elser-2-elasticsearch');
expect(rows[2]).toHaveTextContent('.multilingual-e5-small-elasticsearch');
expect(rows[3]).toHaveTextContent('local-model');
expect(rows[4]).toHaveTextContent('my-elser-model-05');
expect(rows[5]).toHaveTextContent('third-party-model');
Expand Down