Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labelledby to index details flyout to tell screen reader what to announce when the flyout is opened #19776

Merged

Conversation

cjcenizal
Copy link
Contributor

Applies guidance from elastic/eui#916 and fixes #19483.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@cjcenizal cjcenizal merged commit 8657a9e into elastic:master Jun 14, 2018
@cjcenizal cjcenizal deleted the index-details-flyout-accessibility branch June 14, 2018 00:01
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 14, 2018
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 14, 2018
cjcenizal added a commit that referenced this pull request Jun 14, 2018
cjcenizal added a commit that referenced this pull request Jun 14, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual index management page is not announced in screenreader when launched
3 participants