Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Watcher's watch-type-select directive with two buttons. #19782

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

cjcenizal
Copy link
Contributor

Fixes #19475

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Great work @cjcenizal! LGTM!

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran locally and verified functionality

screen shot 2018-06-13 at 10 17 58 am

@bhavyarm
Copy link
Contributor

Tested this and this works fine from accessibility. Thanks CJ and cheers!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants