Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Transplant infra-ui into x-pack #19793

Merged
merged 2 commits into from
Jul 6, 2018
Merged

[Infra] Transplant infra-ui into x-pack #19793

merged 2 commits into from
Jul 6, 2018

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Jun 11, 2018 •
edited
Loading

Preparations

Task Breakdown

  • fix linter errors
  • adapt to RxJS 6
  • merge package.jsons
  • remove broken and unneccessary timefilter
  • set up CI for the feature branch

@weltenwort weltenwort self-assigned this Jun 11, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@epixa
Copy link
Contributor

epixa commented Jun 11, 2018

All the .ts files in this PR need the appropriate license header. I'm not sure why tslint --fix didn't add them.

@weltenwort
Copy link
Member Author

It's probably my fault, because I assembled this PR from some older experiments. I'll go over it once more to fix the rest of the linter errors soon.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort force-pushed the enhancement-integrate-infra-ui branch from 4c4e90b to 9d5f029 Compare June 26, 2018 17:07
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort changed the base branch from master to feature-infra-ui July 3, 2018 12:39
@weltenwort
Transplant infra-ui into x-pack
55076cb 
Includes many automatic fixes by tslint.
@weltenwort weltenwort force-pushed the enhancement-integrate-infra-ui branch from e37bed6 to 55076cb Compare July 3, 2018 13:08
@weltenwort weltenwort mentioned this pull request Jul 3, 2018
Merged
@weltenwort weltenwort added the Feature:Metrics UI Metrics UI feature label Jul 4, 2018
@weltenwort
Copy link
Member Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

CI jobs have been set up, there are just a few details to work out in the build scripts.

@weltenwort weltenwort merged commit 83e2e7c into elastic:feature-infra-ui Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@weltenwort weltenwort

Labels
Feature:Metrics UI Metrics UI feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weltenwort @elasticmachine @epixa @simianhacker