[Infra UI] Replace jump menu with EUI datepicker #20422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
changed the title
4 tasks
weltenwort
force-pushed
the
infra-ui-enhancement-eui-datepicker
branch
from
f2da831 to
bb20bd7
Compare
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-enhancement-eui-datepicker
branch
from
a6dd6f4 to
c25b752
Compare
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-enhancement-eui-datepicker
branch
from
c25b752 to
8a6386d
Compare
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-enhancement-eui-datepicker
branch
from
8a6386d to
2f82f2a
Compare
This replaces the "Jump to time" menu with the EUI datepicker. It also tweaks the design of the streaming toggle. The date and time formats of the datepicker are depend on the current browser locale via the corresponding Moment.js format string tokens.
This wraps the `ScrollableLogTextStreamView` in a HoC, which in turn uses the `withStateFromLocation` HoC to retrieve the scroll state from the URL. It also updates the location accordingly when the visible log interval changes. The connection between the location and the app state is implemented as a HoC, because the location can be seen as a part of the UI. Additionally, this keeps the implementation agnostic of the state management used in the app, be it redux or apollo-link-state. The serialization is performed using the `mapStateToRisonAppLocation` and `mapRisonAppLocationToState` functions, that use the `_a` key of the query string for the sake of consistency with many parts of Kibana.
weltenwort
force-pushed
the
infra-ui-enhancement-eui-datepicker
branch
from
2f82f2a to
4c588e2
Compare
weltenwort
changed the title
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the "Jump to time" menu with the EUI datepicker. It also tweaks the design of the streaming toggle. The date and time formats of the datepicker are depend on the current browser locale via the corresponding Moment.js format string tokens.
It also stores the current scroll state of the log view in the url such that it persists across reloads and can be shared between users.
Normal
Open
Streaming
