[Stack Monitoring / Logs] Fix Stack Monitoring logs links #200043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
v9.0.0
v8.17.0
v8.16.1
backport:version
Kerry350
commented
Nov 13, 2024
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
mohamedhamed-ahmed
added
the
release_note:skip
|
/oblt-deploy |
|
/oblt-deploy |
⏳ Build in-progress
History
cc @Kerry350 |
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11842355455 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 14, 2024
…0043) ## Summary Fixes elastic#199902 (comment). This was missed in elastic#190835 due to Stack Monitoring's lack of type checking in certain files. `infra` no longer exposes `logsLocators`. This uses `getLogsLocatorsFromUrlService`, technically we could go to Discover now knowing that Logs Explorer will be deprecated in the future. But it will make more sense to convert `getLogsLocatorsFromUrlService` over to using the Discover locators in one when that happens. This puts us on the same page as elastic#190835. This link should now work, and have the correct filters applied.  --------- Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co> (cherry picked from commit 4e852ea)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mohamedhamed-ahmed
pushed a commit
to mohamedhamed-ahmed/kibana
that referenced
this pull request
Nov 14, 2024
…0043) ## Summary Fixes elastic#199902 (comment). This was missed in elastic#190835 due to Stack Monitoring's lack of type checking in certain files. `infra` no longer exposes `logsLocators`. This uses `getLogsLocatorsFromUrlService`, technically we could go to Discover now knowing that Logs Explorer will be deprecated in the future. But it will make more sense to convert `getLogsLocatorsFromUrlService` over to using the Discover locators in one when that happens. This puts us on the same page as elastic#190835. This link should now work, and have the correct filters applied.  --------- Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co> (cherry picked from commit 4e852ea) # Conflicts: # x-pack/plugins/monitoring/kibana.jsonc
kibanamachine
added a commit
that referenced
this pull request
Nov 14, 2024
) (#200227) # Backport This will backport the following commits from `main` to `8.x`: - [[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)](#200043) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"kerry.gallagher@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T17:26:24Z","message":"[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)\n\n## Summary\r\n\r\nFixes\r\nhttps://github.com//issues/199902#issuecomment-2474040264.\r\n\r\nThis was missed in #190835 due to\r\nStack Monitoring's lack of type checking in certain files. `infra` no\r\nlonger exposes `logsLocators`.\r\n\r\nThis uses `getLogsLocatorsFromUrlService`, technically we could go to\r\nDiscover now knowing that Logs Explorer will be deprecated in the\r\nfuture. But it will make more sense to convert\r\n`getLogsLocatorsFromUrlService` over to using the Discover locators in\r\none when that happens. This puts us on the same page as\r\nhttps://github.com//pull/190835.\r\n\r\nThis link should now work, and have the correct filters applied.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>","sha":"4e852ea041b63e3e3ad918ceee1bc3861dd1e519","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:cloud-deploy","Team:obs-ux-logs","backport:version","v8.17.0","v8.16.1"],"title":"[Stack Monitoring / Logs] Fix Stack Monitoring logs links","number":200043,"url":"https://github.com/elastic/kibana/pull/200043","mergeCommit":{"message":"[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)\n\n## Summary\r\n\r\nFixes\r\nhttps://github.com//issues/199902#issuecomment-2474040264.\r\n\r\nThis was missed in #190835 due to\r\nStack Monitoring's lack of type checking in certain files. `infra` no\r\nlonger exposes `logsLocators`.\r\n\r\nThis uses `getLogsLocatorsFromUrlService`, technically we could go to\r\nDiscover now knowing that Logs Explorer will be deprecated in the\r\nfuture. But it will make more sense to convert\r\n`getLogsLocatorsFromUrlService` over to using the Discover locators in\r\none when that happens. This puts us on the same page as\r\nhttps://github.com//pull/190835.\r\n\r\nThis link should now work, and have the correct filters applied.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>","sha":"4e852ea041b63e3e3ad918ceee1bc3861dd1e519"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200043","number":200043,"mergeCommit":{"message":"[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)\n\n## Summary\r\n\r\nFixes\r\nhttps://github.com//issues/199902#issuecomment-2474040264.\r\n\r\nThis was missed in #190835 due to\r\nStack Monitoring's lack of type checking in certain files. `infra` no\r\nlonger exposes `logsLocators`.\r\n\r\nThis uses `getLogsLocatorsFromUrlService`, technically we could go to\r\nDiscover now knowing that Logs Explorer will be deprecated in the\r\nfuture. But it will make more sense to convert\r\n`getLogsLocatorsFromUrlService` over to using the Discover locators in\r\none when that happens. This puts us on the same page as\r\nhttps://github.com//pull/190835.\r\n\r\nThis link should now work, and have the correct filters applied.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>","sha":"4e852ea041b63e3e3ad918ceee1bc3861dd1e519"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <kerry.gallagher@elastic.co>
mohamedhamed-ahmed
added a commit
that referenced
this pull request
Nov 14, 2024
…0043) (#200231) # Backport This will backport the following commits from `main` to `8.16`: - [[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)](#200043) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"kerry.gallagher@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T17:26:24Z","message":"[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)\n\n## Summary\r\n\r\nFixes\r\nhttps://github.com//issues/199902#issuecomment-2474040264.\r\n\r\nThis was missed in #190835 due to\r\nStack Monitoring's lack of type checking in certain files. `infra` no\r\nlonger exposes `logsLocators`.\r\n\r\nThis uses `getLogsLocatorsFromUrlService`, technically we could go to\r\nDiscover now knowing that Logs Explorer will be deprecated in the\r\nfuture. But it will make more sense to convert\r\n`getLogsLocatorsFromUrlService` over to using the Discover locators in\r\none when that happens. This puts us on the same page as\r\nhttps://github.com//pull/190835.\r\n\r\nThis link should now work, and have the correct filters applied.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>","sha":"4e852ea041b63e3e3ad918ceee1bc3861dd1e519","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:cloud-deploy","Team:obs-ux-logs","backport:version","v8.17.0","v8.16.1"],"number":200043,"url":"https://github.com/elastic/kibana/pull/200043","mergeCommit":{"message":"[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)\n\n## Summary\r\n\r\nFixes\r\nhttps://github.com//issues/199902#issuecomment-2474040264.\r\n\r\nThis was missed in #190835 due to\r\nStack Monitoring's lack of type checking in certain files. `infra` no\r\nlonger exposes `logsLocators`.\r\n\r\nThis uses `getLogsLocatorsFromUrlService`, technically we could go to\r\nDiscover now knowing that Logs Explorer will be deprecated in the\r\nfuture. But it will make more sense to convert\r\n`getLogsLocatorsFromUrlService` over to using the Discover locators in\r\none when that happens. This puts us on the same page as\r\nhttps://github.com//pull/190835.\r\n\r\nThis link should now work, and have the correct filters applied.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>","sha":"4e852ea041b63e3e3ad918ceee1bc3861dd1e519"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200043","number":200043,"mergeCommit":{"message":"[Stack Monitoring / Logs] Fix Stack Monitoring logs links (#200043)\n\n## Summary\r\n\r\nFixes\r\nhttps://github.com//issues/199902#issuecomment-2474040264.\r\n\r\nThis was missed in #190835 due to\r\nStack Monitoring's lack of type checking in certain files. `infra` no\r\nlonger exposes `logsLocators`.\r\n\r\nThis uses `getLogsLocatorsFromUrlService`, technically we could go to\r\nDiscover now knowing that Logs Explorer will be deprecated in the\r\nfuture. But it will make more sense to convert\r\n`getLogsLocatorsFromUrlService` over to using the Discover locators in\r\none when that happens. This puts us on the same page as\r\nhttps://github.com//pull/190835.\r\n\r\nThis link should now work, and have the correct filters applied.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>","sha":"4e852ea041b63e3e3ad918ceee1bc3861dd1e519"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/200227","number":200227,"state":"OPEN"},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <kerry.gallagher@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…0043) ## Summary Fixes elastic#199902 (comment). This was missed in elastic#190835 due to Stack Monitoring's lack of type checking in certain files. `infra` no longer exposes `logsLocators`. This uses `getLogsLocatorsFromUrlService`, technically we could go to Discover now knowing that Logs Explorer will be deprecated in the future. But it will make more sense to convert `getLogsLocatorsFromUrlService` over to using the Discover locators in one when that happens. This puts us on the same page as elastic#190835. This link should now work, and have the correct filters applied.  --------- Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…0043) ## Summary Fixes elastic#199902 (comment). This was missed in elastic#190835 due to Stack Monitoring's lack of type checking in certain files. `infra` no longer exposes `logsLocators`. This uses `getLogsLocatorsFromUrlService`, technically we could go to Discover now knowing that Logs Explorer will be deprecated in the future. But it will make more sense to convert `getLogsLocatorsFromUrlService` over to using the Discover locators in one when that happens. This puts us on the same page as elastic#190835. This link should now work, and have the correct filters applied.  --------- Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #199902 (comment).
This was missed in #190835 due to Stack Monitoring's lack of type checking in certain files.
infrano longer exposeslogsLocators.This uses
getLogsLocatorsFromUrlService, technically we could go to Discover now knowing that Logs Explorer will be deprecated in the future. But it will make more sense to convertgetLogsLocatorsFromUrlServiceover to using the Discover locators in one when that happens. This puts us on the same page as #190835.This link should now work, and have the correct filters applied.