Add support back in for CCS in Stack Monitoring #200256
Assignees
Labels
Team:obs-ux-logs
Observability Logs User Experience Team
Comments
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 28, 2024
…in Stack Monitoring (elastic#200546) ## Summary Closes elastic#200256 and elastic#200218. ## Overview of changes - The call to `logsShared.logViews.defineInternalLogView()` is removed as Log Views will be deprecated. - The logs indices that were previously defined via `defineInternalLogView()` are now exposed via `externalConfig.logsIndices` - As part of this change `ui.logs` from `config` is now exposed to browser. Given this is just an index pattern I don't believe there are any security concerns here. - `getIndexPatterns()` has been moved to common (this makes it look like there's a lot of file changes here). - The Logs Explorer locator is swapped for the Discover locator using an ad-hoc data view. - This is hidden if Discover isn't available. The behaviour here should match exactly what we had before, as the same indices are constructed from `getIndexPatterns()` and we apply the same `query`. Stack Monitoring reviewer: The path changes from moving `getIndexPatterns()` were automated so there shouldn't be any issues, but given it's used extensively please check everything works as expected. ## Screenshots   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3e538d6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 28, 2024
…in Stack Monitoring (elastic#200546) ## Summary Closes elastic#200256 and elastic#200218. ## Overview of changes - The call to `logsShared.logViews.defineInternalLogView()` is removed as Log Views will be deprecated. - The logs indices that were previously defined via `defineInternalLogView()` are now exposed via `externalConfig.logsIndices` - As part of this change `ui.logs` from `config` is now exposed to browser. Given this is just an index pattern I don't believe there are any security concerns here. - `getIndexPatterns()` has been moved to common (this makes it look like there's a lot of file changes here). - The Logs Explorer locator is swapped for the Discover locator using an ad-hoc data view. - This is hidden if Discover isn't available. The behaviour here should match exactly what we had before, as the same indices are constructed from `getIndexPatterns()` and we apply the same `query`. Stack Monitoring reviewer: The path changes from moving `getIndexPatterns()` were automated so there shouldn't be any issues, but given it's used extensively please check everything works as expected. ## Screenshots   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3e538d6)
kibanamachine
added a commit
that referenced
this issue
Nov 28, 2024
…cator in Stack Monitoring (#200546) (#202137) # Backport This will backport the following commits from `main` to `8.x`: - [[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)](#200546) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"kerry.gallagher@elastic.co"},"sourceCommit":{"committedDate":"2024-11-28T10:52:38Z","message":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)\n\n## Summary\r\n\r\nCloses #200256 and\r\nhttps://github.com//issues/200218.\r\n\r\n## Overview of changes\r\n\r\n- The call to `logsShared.logViews.defineInternalLogView()` is removed\r\nas Log Views will be deprecated.\r\n- The logs indices that were previously defined via\r\n`defineInternalLogView()` are now exposed via\r\n`externalConfig.logsIndices`\r\n- As part of this change `ui.logs` from `config` is now exposed to\r\nbrowser. Given this is just an index pattern I don't believe there are\r\nany security concerns here.\r\n- `getIndexPatterns()` has been moved to common (this makes it look like\r\nthere's a lot of file changes here).\r\n- The Logs Explorer locator is swapped for the Discover locator using an\r\nad-hoc data view.\r\n - This is hidden if Discover isn't available.\r\n\r\nThe behaviour here should match exactly what we had before, as the same\r\nindices are constructed from `getIndexPatterns()` and we apply the same\r\n`query`.\r\n\r\nStack Monitoring reviewer: The path changes from moving\r\n`getIndexPatterns()` were automated so there shouldn't be any issues,\r\nbut given it's used extensively please check everything works as\r\nexpected.\r\n\r\n## Screenshots\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3e538d67c1378dc438d9f81cb603a7965026ac0c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-logs","backport:version","v8.18.0","v8.16.2"],"title":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring","number":200546,"url":"https://github.com/elastic/kibana/pull/200546","mergeCommit":{"message":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)\n\n## Summary\r\n\r\nCloses #200256 and\r\nhttps://github.com//issues/200218.\r\n\r\n## Overview of changes\r\n\r\n- The call to `logsShared.logViews.defineInternalLogView()` is removed\r\nas Log Views will be deprecated.\r\n- The logs indices that were previously defined via\r\n`defineInternalLogView()` are now exposed via\r\n`externalConfig.logsIndices`\r\n- As part of this change `ui.logs` from `config` is now exposed to\r\nbrowser. Given this is just an index pattern I don't believe there are\r\nany security concerns here.\r\n- `getIndexPatterns()` has been moved to common (this makes it look like\r\nthere's a lot of file changes here).\r\n- The Logs Explorer locator is swapped for the Discover locator using an\r\nad-hoc data view.\r\n - This is hidden if Discover isn't available.\r\n\r\nThe behaviour here should match exactly what we had before, as the same\r\nindices are constructed from `getIndexPatterns()` and we apply the same\r\n`query`.\r\n\r\nStack Monitoring reviewer: The path changes from moving\r\n`getIndexPatterns()` were automated so there shouldn't be any issues,\r\nbut given it's used extensively please check everything works as\r\nexpected.\r\n\r\n## Screenshots\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3e538d67c1378dc438d9f81cb603a7965026ac0c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200546","number":200546,"mergeCommit":{"message":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)\n\n## Summary\r\n\r\nCloses #200256 and\r\nhttps://github.com//issues/200218.\r\n\r\n## Overview of changes\r\n\r\n- The call to `logsShared.logViews.defineInternalLogView()` is removed\r\nas Log Views will be deprecated.\r\n- The logs indices that were previously defined via\r\n`defineInternalLogView()` are now exposed via\r\n`externalConfig.logsIndices`\r\n- As part of this change `ui.logs` from `config` is now exposed to\r\nbrowser. Given this is just an index pattern I don't believe there are\r\nany security concerns here.\r\n- `getIndexPatterns()` has been moved to common (this makes it look like\r\nthere's a lot of file changes here).\r\n- The Logs Explorer locator is swapped for the Discover locator using an\r\nad-hoc data view.\r\n - This is hidden if Discover isn't available.\r\n\r\nThe behaviour here should match exactly what we had before, as the same\r\nindices are constructed from `getIndexPatterns()` and we apply the same\r\n`query`.\r\n\r\nStack Monitoring reviewer: The path changes from moving\r\n`getIndexPatterns()` were automated so there shouldn't be any issues,\r\nbut given it's used extensively please check everything works as\r\nexpected.\r\n\r\n## Screenshots\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3e538d67c1378dc438d9f81cb603a7965026ac0c"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <kerry.gallagher@elastic.co>
kibanamachine
added a commit
that referenced
this issue
Nov 28, 2024
…ocator in Stack Monitoring (#200546) (#202136) # Backport This will backport the following commits from `main` to `8.16`: - [[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)](#200546) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"kerry.gallagher@elastic.co"},"sourceCommit":{"committedDate":"2024-11-28T10:52:38Z","message":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)\n\n## Summary\r\n\r\nCloses #200256 and\r\nhttps://github.com//issues/200218.\r\n\r\n## Overview of changes\r\n\r\n- The call to `logsShared.logViews.defineInternalLogView()` is removed\r\nas Log Views will be deprecated.\r\n- The logs indices that were previously defined via\r\n`defineInternalLogView()` are now exposed via\r\n`externalConfig.logsIndices`\r\n- As part of this change `ui.logs` from `config` is now exposed to\r\nbrowser. Given this is just an index pattern I don't believe there are\r\nany security concerns here.\r\n- `getIndexPatterns()` has been moved to common (this makes it look like\r\nthere's a lot of file changes here).\r\n- The Logs Explorer locator is swapped for the Discover locator using an\r\nad-hoc data view.\r\n - This is hidden if Discover isn't available.\r\n\r\nThe behaviour here should match exactly what we had before, as the same\r\nindices are constructed from `getIndexPatterns()` and we apply the same\r\n`query`.\r\n\r\nStack Monitoring reviewer: The path changes from moving\r\n`getIndexPatterns()` were automated so there shouldn't be any issues,\r\nbut given it's used extensively please check everything works as\r\nexpected.\r\n\r\n## Screenshots\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3e538d67c1378dc438d9f81cb603a7965026ac0c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-logs","backport:version","v8.18.0","v8.16.2"],"title":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring","number":200546,"url":"https://github.com/elastic/kibana/pull/200546","mergeCommit":{"message":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)\n\n## Summary\r\n\r\nCloses #200256 and\r\nhttps://github.com//issues/200218.\r\n\r\n## Overview of changes\r\n\r\n- The call to `logsShared.logViews.defineInternalLogView()` is removed\r\nas Log Views will be deprecated.\r\n- The logs indices that were previously defined via\r\n`defineInternalLogView()` are now exposed via\r\n`externalConfig.logsIndices`\r\n- As part of this change `ui.logs` from `config` is now exposed to\r\nbrowser. Given this is just an index pattern I don't believe there are\r\nany security concerns here.\r\n- `getIndexPatterns()` has been moved to common (this makes it look like\r\nthere's a lot of file changes here).\r\n- The Logs Explorer locator is swapped for the Discover locator using an\r\nad-hoc data view.\r\n - This is hidden if Discover isn't available.\r\n\r\nThe behaviour here should match exactly what we had before, as the same\r\nindices are constructed from `getIndexPatterns()` and we apply the same\r\n`query`.\r\n\r\nStack Monitoring reviewer: The path changes from moving\r\n`getIndexPatterns()` were automated so there shouldn't be any issues,\r\nbut given it's used extensively please check everything works as\r\nexpected.\r\n\r\n## Screenshots\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3e538d67c1378dc438d9f81cb603a7965026ac0c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200546","number":200546,"mergeCommit":{"message":"[Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546)\n\n## Summary\r\n\r\nCloses #200256 and\r\nhttps://github.com//issues/200218.\r\n\r\n## Overview of changes\r\n\r\n- The call to `logsShared.logViews.defineInternalLogView()` is removed\r\nas Log Views will be deprecated.\r\n- The logs indices that were previously defined via\r\n`defineInternalLogView()` are now exposed via\r\n`externalConfig.logsIndices`\r\n- As part of this change `ui.logs` from `config` is now exposed to\r\nbrowser. Given this is just an index pattern I don't believe there are\r\nany security concerns here.\r\n- `getIndexPatterns()` has been moved to common (this makes it look like\r\nthere's a lot of file changes here).\r\n- The Logs Explorer locator is swapped for the Discover locator using an\r\nad-hoc data view.\r\n - This is hidden if Discover isn't available.\r\n\r\nThe behaviour here should match exactly what we had before, as the same\r\nindices are constructed from `getIndexPatterns()` and we apply the same\r\n`query`.\r\n\r\nStack Monitoring reviewer: The path changes from moving\r\n`getIndexPatterns()` were automated so there shouldn't be any issues,\r\nbut given it's used extensively please check everything works as\r\nexpected.\r\n\r\n## Screenshots\r\n\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"3e538d67c1378dc438d9f81cb603a7965026ac0c"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <kerry.gallagher@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the change implemented in #200043 Stack Monitoring uses the Logs Explorer locator which doesn't support CCS. This issue will replace the Logs Explorer locator for the Discover locator so that we can use an ad-hoc data view to maintain the CCS indices.
The text was updated successfully, but these errors were encountered: