[8.x] [Stack Monitoring] Switch Logs Explorer locator for Discover locator in Stack Monitoring (#200546) #202137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Stack Monitoring (elastic#200546) ## Summary Closes elastic#200256 and elastic#200218. ## Overview of changes - The call to `logsShared.logViews.defineInternalLogView()` is removed as Log Views will be deprecated. - The logs indices that were previously defined via `defineInternalLogView()` are now exposed via `externalConfig.logsIndices` - As part of this change `ui.logs` from `config` is now exposed to browser. Given this is just an index pattern I don't believe there are any security concerns here. - `getIndexPatterns()` has been moved to common (this makes it look like there's a lot of file changes here). - The Logs Explorer locator is swapped for the Discover locator using an ad-hoc data view. - This is hidden if Discover isn't available. The behaviour here should match exactly what we had before, as the same indices are constructed from `getIndexPatterns()` and we apply the same `query`. Stack Monitoring reviewer: The path changes from moving `getIndexPatterns()` were automated so there shouldn't be any issues, but given it's used extensively please check everything works as expected. ## Screenshots   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3e538d6)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
cc @Kerry350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation