Fix Custom Threshold Rule ViewInAppUrl does not honor space
#201793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
maryam-saeidi
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Tested with changes mentioned here, and it worked as expected 🚀
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
…ant/kibana into d/2024-11-26-locators-space-redirect
sebelga
approved these changes
Nov 28, 2024
src/plugins/share/common/url_service/locators/redirect/space_url_parser.test.ts
Outdated
Show resolved
Hide resolved
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
pheyos
approved these changes
Nov 29, 2024
Dosant
changed the title
spaceId in getRedirectUrlViewInAppUrl does not honour Space
Dosant
changed the title
ViewInAppUrl does not honour SpaceViewInAppUrl does not honor space
Dosant
removed
the
backport:prev-minor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7572[✅] x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts: 25/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7571[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts: 25/25 tests passed. |
|
Unfortunately, running the whole test config against MKI still fails for me :(
I am looking into replacing synthtrace with data-forge. |
|
Finally!
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7573[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts: 25/25 tests passed. |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Page load bundle
History
|
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12273608116 |
|
Great job @maryam-saeidi on following through with tests 👏 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
…c#201793) ## Summary Close elastic#201378 Fix elastic#201333 - [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL with a specific `spaceId` - Fix Custom Threshold Rule ViewInAppUrl does not honor Space --------- Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co> (cherry picked from commit f1f3a4f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
…c#201793) ## Summary Close elastic#201378 Fix elastic#201333 - [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL with a specific `spaceId` - Fix Custom Threshold Rule ViewInAppUrl does not honor Space --------- Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co> (cherry picked from commit f1f3a4f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2024
…or space (#201793) (#203736) # Backport This will backport the following commits from `main` to `8.x`: - [Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)](#201793) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-12-11T09:39:01Z","message":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/201378\r\nFix https://github.com/elastic/kibana/issues/201333\r\n\r\n- [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL\r\nwith a specific `spaceId`\r\n- Fix Custom Threshold Rule ViewInAppUrl does not honor Space\r\n\r\n---------\r\n\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"f1f3a4fddd34a08e33d2778a09f2166d6d1b02a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.18.0","v8.17.1"],"title":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space","number":201793,"url":"https://github.com/elastic/kibana/pull/201793","mergeCommit":{"message":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/201378\r\nFix https://github.com/elastic/kibana/issues/201333\r\n\r\n- [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL\r\nwith a specific `spaceId`\r\n- Fix Custom Threshold Rule ViewInAppUrl does not honor Space\r\n\r\n---------\r\n\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"f1f3a4fddd34a08e33d2778a09f2166d6d1b02a0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201793","number":201793,"mergeCommit":{"message":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/201378\r\nFix https://github.com/elastic/kibana/issues/201333\r\n\r\n- [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL\r\nwith a specific `spaceId`\r\n- Fix Custom Threshold Rule ViewInAppUrl does not honor Space\r\n\r\n---------\r\n\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"f1f3a4fddd34a08e33d2778a09f2166d6d1b02a0"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2024
…nor space (#201793) (#203735) # Backport This will backport the following commits from `main` to `8.17`: - [Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)](#201793) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-12-11T09:39:01Z","message":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/201378\r\nFix https://github.com/elastic/kibana/issues/201333\r\n\r\n- [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL\r\nwith a specific `spaceId`\r\n- Fix Custom Threshold Rule ViewInAppUrl does not honor Space\r\n\r\n---------\r\n\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"f1f3a4fddd34a08e33d2778a09f2166d6d1b02a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.18.0","v8.17.1"],"title":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space","number":201793,"url":"https://github.com/elastic/kibana/pull/201793","mergeCommit":{"message":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/201378\r\nFix https://github.com/elastic/kibana/issues/201333\r\n\r\n- [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL\r\nwith a specific `spaceId`\r\n- Fix Custom Threshold Rule ViewInAppUrl does not honor Space\r\n\r\n---------\r\n\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"f1f3a4fddd34a08e33d2778a09f2166d6d1b02a0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201793","number":201793,"mergeCommit":{"message":"Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/201378\r\nFix https://github.com/elastic/kibana/issues/201333\r\n\r\n- [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL\r\nwith a specific `spaceId`\r\n- Fix Custom Threshold Rule ViewInAppUrl does not honor Space\r\n\r\n---------\r\n\r\nCo-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>","sha":"f1f3a4fddd34a08e33d2778a09f2166d6d1b02a0"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…c#201793) ## Summary Close elastic#201378 Fix elastic#201333 - [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL with a specific `spaceId` - Fix Custom Threshold Rule ViewInAppUrl does not honor Space --------- Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
|
Thank you @maryam-saeidi, for the follow-up 💪🏻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #201378
Fix #201333
spaceIdtogetRedirectUrlto build a URL with a specificspaceId