Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17] Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793) #203735

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[8.17] Fix Custom Threshold Rule `ViewInAppUrl` does not honor space (#201793) #203735

merged 1 commit into from
Dec 11, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

@Dosant
Fix Custom Threshold Rule ViewInAppUrl does not honor space (elasti…
f2c2df4 
…c#201793)

## Summary

Close elastic#201378
Fix elastic#201333

- [Share] Allow to pass `spaceId` to `getRedirectUrl` to build a URL
with a specific `spaceId`
- Fix Custom Threshold Rule ViewInAppUrl does not honor Space

---------

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
(cherry picked from commit f1f3a4f)
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Dec 11, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) December 11, 2024 09:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine mentioned this pull request Dec 11, 2024
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 11, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: f2c2df4
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203735-f2c2df4a11b2

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 93 94 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 104.1KB 104.1KB +22.0B
share 57.9KB 58.1KB +268.0B
total +290.0B

History

cc @Dosant

@kibanamachine kibanamachine merged commit 894aca4 into elastic:8.17 Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Dosant Dosant

Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @Dosant