[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift #205170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
release_note:fix
:ml
Feature:File and Index Data Viz
|
Pinging @elastic/ml-ui (:ml) |
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12550052338 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 30, 2024
…Data Drift (elastic#205170) ## Summary This PR fixes elastic#204392 side bar navigation not highlighted for Data Visualizer and Data Drift <img width="1134" alt="Screenshot 2024-12-26 at 12 32 00" src="https://github.com/user-attachments/assets/ff721a06-74b8-4103-9a3d-64a60b0284c8" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 48" src="https://github.com/user-attachments/assets/e4250d70-d1a2-4a5b-b891-a935fa554e79" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 42" src="https://github.com/user-attachments/assets/4c599233-4dfc-48b1-9612-5798c51f60ea" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 6556346)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 30, 2024
…r and Data Drift (#205170) (#205284) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift (#205170)](#205170) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quynh Nguyen (Quinn)","email":"43350163+qn895@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-30T17:51:37Z","message":"[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift (#205170)\n\n## Summary\r\n\r\nThis PR fixes #204392 side bar\r\nnavigation not highlighted for Data Visualizer and Data Drift\r\n\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 32 00\"\r\nsrc=\"https://github.com/user-attachments/assets/ff721a06-74b8-4103-9a3d-64a60b0284c8\"\r\n/>\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 31 48\"\r\nsrc=\"https://github.com/user-attachments/assets/e4250d70-d1a2-4a5b-b891-a935fa554e79\"\r\n/>\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 31 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4c599233-4dfc-48b1-9612-5798c51f60ea\"\r\n/>\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] [See some risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n- [ ] ...\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"6556346d7351eceaed8c82ab6b892932afeed02f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:File and Index Data Viz","v9.0.0","backport:version","v8.18.0"],"title":"[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift","number":205170,"url":"https://github.com/elastic/kibana/pull/205170","mergeCommit":{"message":"[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift (#205170)\n\n## Summary\r\n\r\nThis PR fixes #204392 side bar\r\nnavigation not highlighted for Data Visualizer and Data Drift\r\n\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 32 00\"\r\nsrc=\"https://github.com/user-attachments/assets/ff721a06-74b8-4103-9a3d-64a60b0284c8\"\r\n/>\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 31 48\"\r\nsrc=\"https://github.com/user-attachments/assets/e4250d70-d1a2-4a5b-b891-a935fa554e79\"\r\n/>\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 31 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4c599233-4dfc-48b1-9612-5798c51f60ea\"\r\n/>\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] [See some risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n- [ ] ...\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"6556346d7351eceaed8c82ab6b892932afeed02f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205170","number":205170,"mergeCommit":{"message":"[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift (#205170)\n\n## Summary\r\n\r\nThis PR fixes #204392 side bar\r\nnavigation not highlighted for Data Visualizer and Data Drift\r\n\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 32 00\"\r\nsrc=\"https://github.com/user-attachments/assets/ff721a06-74b8-4103-9a3d-64a60b0284c8\"\r\n/>\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 31 48\"\r\nsrc=\"https://github.com/user-attachments/assets/e4250d70-d1a2-4a5b-b891-a935fa554e79\"\r\n/>\r\n<img width=\"1134\" alt=\"Screenshot 2024-12-26 at 12 31 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4c599233-4dfc-48b1-9612-5798c51f60ea\"\r\n/>\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] [See some risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n- [ ] ...\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"6556346d7351eceaed8c82ab6b892932afeed02f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
…Data Drift (elastic#205170) ## Summary This PR fixes elastic#204392 side bar navigation not highlighted for Data Visualizer and Data Drift <img width="1134" alt="Screenshot 2024-12-26 at 12 32 00" src="https://github.com/user-attachments/assets/ff721a06-74b8-4103-9a3d-64a60b0284c8" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 48" src="https://github.com/user-attachments/assets/e4250d70-d1a2-4a5b-b891-a935fa554e79" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 42" src="https://github.com/user-attachments/assets/4c599233-4dfc-48b1-9612-5798c51f60ea" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…Data Drift (elastic#205170) ## Summary This PR fixes elastic#204392 side bar navigation not highlighted for Data Visualizer and Data Drift <img width="1134" alt="Screenshot 2024-12-26 at 12 32 00" src="https://github.com/user-attachments/assets/ff721a06-74b8-4103-9a3d-64a60b0284c8" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 48" src="https://github.com/user-attachments/assets/e4250d70-d1a2-4a5b-b891-a935fa554e79" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 42" src="https://github.com/user-attachments/assets/4c599233-4dfc-48b1-9612-5798c51f60ea" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
…Data Drift (elastic#205170) ## Summary This PR fixes elastic#204392 side bar navigation not highlighted for Data Visualizer and Data Drift <img width="1134" alt="Screenshot 2024-12-26 at 12 32 00" src="https://github.com/user-attachments/assets/ff721a06-74b8-4103-9a3d-64a60b0284c8" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 48" src="https://github.com/user-attachments/assets/e4250d70-d1a2-4a5b-b891-a935fa554e79" /> <img width="1134" alt="Screenshot 2024-12-26 at 12 31 42" src="https://github.com/user-attachments/assets/4c599233-4dfc-48b1-9612-5798c51f60ea" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #204392 side bar navigation not highlighted for Data Visualizer and Data Drift
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.