Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift #205170

Merged
merged 2 commits into from
Dec 30, 2024
Merged

[ML] Fix side bar navigation not highlighted for Data Visualizer and Data Drift #205170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c81099
Fix sidenav not selected
qn895 Dec 26, 2024
48b8d43
Merge branch 'main' into ml-dataviz-datadrift-sidenav
elasticmachine Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion x-pack/platform/plugins/shared/ml/public/application/components/ml_page/side_nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ export function useSideNavItems(activeRoute: MlRoute | undefined) {
}),
disabled: false,
testSubj: 'mlMainTab indexDataVisualizer',
relatedRouteIds: ['data_view_datavisualizer'],
},
{
id: 'esql_datavisualizer',
Expand All @@ -255,6 +256,7 @@ export function useSideNavItems(activeRoute: MlRoute | undefined) {
}),
disabled: false,
testSubj: 'mlMainTab esqlDataVisualizer',
relatedRouteIds: ['data_view_datavisualizer_esql'],
},

{
Expand All @@ -265,6 +267,7 @@ export function useSideNavItems(activeRoute: MlRoute | undefined) {
}),
disabled: disableLinks,
testSubj: 'mlMainTab dataDrift',
relatedRouteIds: ['data_drift'],
},
],
},
Expand Down Expand Up @@ -337,7 +340,6 @@ export function useSideNavItems(activeRoute: MlRoute | undefined) {
`/${pathId}` === activeRoute?.path ||
(!!highlightNestedRoutes && activeRoute?.path.includes(`${pathId}/`)) ||
(Array.isArray(relatedRouteIds) && relatedRouteIds.includes(activeRoute?.id!));

return {
id,
name,
Expand Down
Loading