[Monitoring] APM UI boilerplate #22453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoved from the selection. (elastic#22242)
…ing messages (elastic#22243) * Update buildHierarchicalData test.
* Rebuild modulePath correctly if on Windows * Change how we find dashboard add panel is loaded * Add and use find.byClassName instead of remote * cleanup a comment
elastic#22124) translate tutorials(osquery_logs, php_fpm_metrics, postgresql_logs, postgresql_metrics, prometheus_metrics, rabbitmq_metrics, redis_logs)
elastic#22122) translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubernetes_metrics, logstash_logs, logstash_metrics, memcached_metrics)
elastic#22121) translate tutorials(elasticsearch_metrics, etcd_metrics, golang_metrics, haprozy_metrics, iis_logs)
Upgrades EUI from 3.6.1 => 3.7.0
* [ci] use es snapshots on non pull requests * remove extra export * always clone
…om Kibana filter (elastic#22885) * handle case where value can not be extracted from Kibana filter * review feedback
Yes! I will take a look tomorrow |
LGTM 🎉 🎉 🎉
…stic#22814) This PR addresses parts of elastic#22642: - It gets rid of the use of var that = this;. - dragSelect's action strings are moved to a constants file. - Adds jest tests for the ExplorerSwimlane component. This also fixes the following bugs: - The way we subscribe listeners to the events of the dragSelect library could result in the same event being triggered multiple times. This in turn could cause race conditions when on each event new data gets fetched but in between angular's scope gets updated and could end up in a non-intended way. The result of this were view-by swimlanes not updating correctly or anomaly charts showing non-related charts. This PR fixes it by filtering out consecutive swimlane click events. - When the angular based chart container wrapper directive gets destroyed/re-esetup when using the job pick, it missed unmounting the react component, it didn't trigger componentWillUnmount()and didn't unsubscribe from dragSelectListener.
…ic#22379) Allows Kibana users to configure the max_concurrent_shard_requests param used by Kibana when sending _msearch requests. Exposes the config as an advanced setting. By default we won't send the param at all, relying on the ES default instead.
…lastic#22904) The `deepFreeze()` function used by `core.injectedMetadata` uses a recursive type definition to indicate that all of the child types within the passed argument become readonly, which works fine for objects but represents arrays as objects instead of using the `ReadonlyArray<>` type. This PR fixes the type definition to use a `RecursiveReadonlyArray<>` type that properly represents arrays with their methods like `push()`, and iterates into the array properly to propagate `ReadOnly<>`, as proven by the tests.
* conditionalize Monitoring tests for Cloud testing * make security_page/login wait * revert these files from another PR * revert these files from another PR
tsullivan
reviewed
Sep 11, 2018
| <KuiTableRowCell> | ||
| <div className="monitoringTableCell__name"> | ||
| <EuiLink | ||
| onClick={goToInstance.bind(null, get(props, 'beat.uuid'))} |
There was a problem hiding this comment.
Does just using href work, instead of onClick ?
tsullivan
reviewed
Sep 11, 2018
| instance="{{ pageData.apmSummary.name }}" | ||
| data-test-subj="apmInstancePage" | ||
| > | ||
| <monitoring-apm-server-instance data="pageData"></monitoring-apm-server-instance> |
There was a problem hiding this comment.
We're able to reduce the amount of Angular/React mix by putting a DOM element here for React to mount to, and have the view render react into this template. I've added a helper view controller class called MonitoringViewBaseController. That should help reduce a lot of the boilerplate bulk. IIRC, you don't even need a getPageData function.
public/views/elasticsearch/overview/controller.js is an example
…#21505) * Default to chromium and add deprecation warning for phantom. * use int, not float
tsullivan
reviewed
Sep 11, 2018
| @@ -27,3 +27,6 @@ import './kibana/summary'; | |||
| import './beats/overview'; | |||
| import './beats/listing'; | |||
| import './beats/beat'; | |||
| import './apm/instance'; | |||
| import './apm/instances'; | |||
| import './apm/overview'; | |||
There was a problem hiding this comment.
If we mount react components directly from the Angular view, we should not need any Angular directives. Over time with refactoring, we shouldn't need this file at all
* migrate reporting top nav to sharing menu * pass share extensions to visualize share menu * start creating the reporting panel component * add buttons * generate report generatation URL * require save if url changes * add print layout UI * putting it all together - generate reports from share context menu * ensure copy button fills entire menu width * inject job params functionallity * refactor print layout out of ReportingContentPanel * CSV report generation * disable report generation when app is dirty * update URL when window is resized * remove all the old stuff * clean up CSV report register provider * fix typescript errors * fix functional retests * remove failure_debug folder * close popover when generate button clicked, more work on functional tests * set size on button and text, do not use EuiFormRow * use ReactElement type * move ShareContextMenuExtensionsRegistryProvider to ui/share and create interfaces for registy * strictor typing, do not use hard coded object type name * move registry files to typescript * remove destructuring in the interface * convert createReportingJob to async function, remove unneeded comment
- The aim of this is to more clearly visualize how the timerange of the cell selected in the swimlane relates to the time span shown in the charts. - The most important change is that the vertical date axis ticks no longer are randomly positioned by d3. Instead they are aligned with the cell interval of the swimlane. This way, the date information shown in the swimlane tooltip will always align with the date tick shown left of the emphasized area in the chart. - The highlighted area now features a gray rounded border to resemble the styling of the selected cell in the swimlane. - The chart also fixes where to long chart headers would wrap the "View" link to a new line. - The x/y axis labels blackness has been reduced to reduce emphasis on the labels.
|
@tsullivan Good suggestions around! Thanks for pointing that out. Updated now |
💔 Build Failed |
|
Looks like you got the idea! With the base controller class, you should also be able to see a Loading page render briefly while we're waiting for the page data. If you throttle your network speed a little, you should be able to see it for longer. |
💔 Build Failed |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the boilerplate code necessary to add the APM presence in the monitoring UI. Most of this work is a simple copy/paste from other examples and I wanted to remove it from the main PR to ensure the reviewers had an opportunity to only see the significant code changes.
This includes the following setup, all contained under
x-pack/plugins/monitoring:NOTE: