Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate pie and vaslib_basic_options #23761

Merged
merged 5 commits into from
Oct 16, 2018
Merged

Translate pie and vaslib_basic_options #23761

merged 5 commits into from
Oct 16, 2018

Conversation

tibmt
Copy link
Contributor

@tibmt tibmt commented Oct 3, 2018 •
edited by pavel06081991
Loading

issue #23257
Translation of Pie visualization component

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

pavel06081991
pavel06081991 reviewed Oct 3, 2018
View reviewed changes
src/core_plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.html Outdated
<label
class="kuiSideBarFormRow__label"
for="visualizeBasicSettingsLegendPosition"
i18n-id="kbnVislibVisTypes.controls.vislibBasicOptions.legendPosition"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.controls.vislibBasicOptions.legendPosition => kbnVislibVisTypes.controls.vislibBasicOptions.legendPositionLabel

src/core_plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.html Outdated
<label
class="kuiSideBarFormRow__label"
for="showTooltip"
i18n-id="kbnVislibVisTypes.controls.vislibBasicOptions.showTooltip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.controls.vislibBasicOptions.showTooltip => kbnVislibVisTypes.controls.vislibBasicOptions.showTooltipLabel

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html Outdated
@@ -2,14 +2,17 @@
<div class="form-group">
<div class="kuiSideBarSectionTitle">
<div class="kuiSideBarSectionTitle__text">
Pie Settings
<span i18n-id="kbnVislibVisTypes.editors.pie.pieSettings" i18n-default-message="Pie Settings"></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not create extra span tag, use <div class="kuiSideBarSectionTitle__text"> instead

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html Outdated
@@ -2,14 +2,17 @@
<div class="form-group">
<div class="kuiSideBarSectionTitle">
<div class="kuiSideBarSectionTitle__text">
Pie Settings
<span i18n-id="kbnVislibVisTypes.editors.pie.pieSettings" i18n-default-message="Pie Settings"></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.editors.pie.pieSettings => kbnVislibVisTypes.editors.pie.pieSettingsTitle

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html Outdated
<label
class="kuiSideBarFormRow__label"
for="isDonut"
i18n-id="kbnVislibVisTypes.editors.pie.donut"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.editors.pie.donut => kbnVislibVisTypes.editors.pie.donutLabel

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html Outdated
<label
class="kuiSideBarFormRow__label"
for="truncateLabels"
i18n-id="kbnVislibVisTypes.editors.pie.truncate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.editors.pie.truncate => kbnVislibVisTypes.editors.pie.truncateLabel

src/core_plugins/kbn_vislib_vis_types/public/pie.js Show resolved Hide resolved
src/core_plugins/kbn_vislib_vis_types/public/pie.js Outdated
@@ -67,7 +67,7 @@ export default function HistogramVisType(Private) {
{
group: 'metrics',
name: 'metric',
title: 'Slice Size',
title: i18n('kbnVislibVisTypes.pie.sliceSizeButtonLabel', { defaultMessage: 'Slice Size' }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.pie.sliceSizeButtonLabel => kbnVislibVisTypes.pie.metricTitle

src/core_plugins/kbn_vislib_vis_types/public/pie.js Outdated
@@ -79,7 +79,7 @@ export default function HistogramVisType(Private) {
group: 'buckets',
name: 'segment',
icon: 'fa fa-scissors',
title: 'Split Slices',
title: i18n('kbnVislibVisTypes.pie.splitSlicesButtonLabel', { defaultMessage: 'Split Slices' }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.pie.segmentTitle'

src/core_plugins/kbn_vislib_vis_types/public/pie.js Outdated
@@ -88,7 +88,7 @@ export default function HistogramVisType(Private) {
group: 'buckets',
name: 'split',
icon: 'fa fa-th',
title: 'Split Chart',
title: i18n('kbnVislibVisTypes.pie.splitChartButtonLabel', { defaultMessage: 'Split Chart' }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbnVislibVisTypes.pie.splitChartButtonLabel => kbnVislibVisTypes.pie.splitTitle

pavel06081991
pavel06081991 approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel06081991
Copy link
Contributor

@tibmt please get access to this repository, after that merge master to your branch and add comment 'retest' it will run CI. When CI is green, merge it and backport to 6.x branch

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tibmt tibmt force-pushed the feature/translations/pie branch from 3951278 to 2abfbb7 Compare October 5, 2018 14:46
@elasticmachine
Copy link
Contributor

💔 Build Failed

@tibmt
Copy link
Contributor Author

tibmt commented Oct 8, 2018

retest

pavel06081991
pavel06081991 approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel06081991 pavel06081991 requested a review from timroes October 8, 2018 08:42
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tibmt
Copy link
Contributor Author

tibmt commented Oct 16, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tibmt tibmt merged commit 1f73ea1 into elastic:master Oct 16, 2018
@tibmt tibmt deleted the feature/translations/pie branch October 16, 2018 14:28
spalger pushed a commit that referenced this pull request Oct 16, 2018
Revert "Translate pie and vaslib_basic_options (#23761)"
4fe7d4f 
This reverts commit 1f73ea1.
spalger pushed a commit that referenced this pull request Oct 16, 2018
Revert "doing config migration during config get if necessary" (#24099)
aa85072 
* Revert "Proofreading edits, UI text consistency (#24016)"

This reverts commit f59f1cc.

* Revert "Skip these tests (#24085)"

This reverts commit e79533d.

* Revert "Point at kibana directory for plugin loading (#24049)"

This reverts commit 3a7f5f5.

* Revert "Translate pie and vaslib_basic_options (#23761)"

This reverts commit 1f73ea1.

* Revert "doing config migration during config get if necessary (#23377)"

This reverts commit 0b4f82d.
@tibmt tibmt mentioned this pull request Oct 17, 2018
Merged
tibmt added a commit to tibmt/kibana that referenced this pull request Oct 17, 2018
@tibmt
Translate pie and vaslib_basic_options (elastic#23761)
2155299 
Translate pie and vaslib_basic_options
tibmt added a commit that referenced this pull request Oct 17, 2018
@tibmt
Translate pie and vaslib_basic_options (#23761) (#24124)
8df9757 
Translate pie and vislib_basic_options
maryia-lapata added a commit that referenced this pull request Oct 17, 2018
@maryia-lapata
[6.x] Translations for Tag Cloud (#24065) (#24125)
4410598 
* Translations for Tag Cloud (#24065)

* Translate pie and vaslib_basic_options (#23761) (#24124)

Translate pie and vislib_basic_options

* [I18n] Add one-time binding to angularjs i18n (#23499) (#23965)

* Add one-time binding to angularjs i18n

* Add watcher for values property

* Watch values field only if it is provided

* Fix ci

* Translations for Tag Cloud (#24065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel06081991 pavel06081991 pavel06081991 approved these changes

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
backported Project:i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tibmt @elasticmachine @pavel06081991 @timroes