Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/translate watcher(part_1) #23989

Merged
merged 18 commits into from
Oct 19, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Oct 12, 2018

translate watcher(part_1)

part_2: #24017
part_3: #24066

@Nox911 Nox911 changed the title Feature/translate watcher(pad 1) Feature/translate watcher(part_1) Oct 15, 2018
@Nox911
Copy link
Contributor Author

Nox911 commented Oct 16, 2018

retest

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix some comments

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pavel06081991
Copy link
Contributor

@Nox911 please resolve conflicts with master branch

@pavel06081991 pavel06081991 removed the request for review from maryia-lapata October 17, 2018 14:41
@maryia-lapata maryia-lapata self-requested a review October 18, 2018 12:02
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of small comments

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@maryia-lapata maryia-lapata merged commit 6247189 into elastic:master Oct 19, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Oct 19, 2018
* translate watcher(pad_1)

* fix test

* fix issues

* fix the same id name

* fix default message

* fix issues
maryia-lapata added a commit that referenced this pull request Oct 19, 2018
* translate watcher(pad_1)

* fix test

* fix issues

* fix the same id name

* fix default message

* fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants