-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/translate watcher(part_1) #23989
Feature/translate watcher(part_1) #23989
Conversation
second merge
retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix some comments
x-pack/plugins/watcher/public/sections/watch_detail/components/watch_detail/watch_detail.js
Outdated
Show resolved
Hide resolved
.../sections/watch_detail/components/watch_history_range_filter/watch_history_range_filter.html
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/public/sections/watch_edit/components/json_watch_edit/json_watch_edit.js
Outdated
Show resolved
Hide resolved
...s/watcher/public/sections/watch_edit/components/threshold_watch_edit/threshold_watch_edit.js
Outdated
Show resolved
Hide resolved
...r/public/sections/watch_edit/components/watch_action_mode_table/watch_action_mode_table.html
Outdated
Show resolved
Hide resolved
...her/public/sections/watch_edit/components/watch_edit_title_panel/watch_edit_title_panel.html
Outdated
Show resolved
Hide resolved
...her/public/sections/watch_edit/components/watch_edit_title_panel/watch_edit_title_panel.html
Outdated
Show resolved
Hide resolved
...her/public/sections/watch_edit/components/watch_edit_title_panel/watch_edit_title_panel.html
Outdated
Show resolved
Hide resolved
...y_item/components/watch_history_item_actions_summary/watch_history_item_actions_summary.html
Show resolved
Hide resolved
x-pack/plugins/watcher/public/sections/watch_list/components/watch_list/watch_list.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
@Nox911 please resolve conflicts with master branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of small comments
x-pack/plugins/watcher/public/sections/watch_detail/components/watch_detail/watch_detail.js
Outdated
Show resolved
Hide resolved
...tcher/public/sections/watch_edit/components/watch_edit_title_panel/watch_edit_title_panel.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/public/sections/watch_list/components/watch_list/watch_list.html
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
* translate watcher(pad_1) * fix test * fix issues * fix the same id name * fix default message * fix issues
translate watcher(part_1)
part_2: #24017
part_3: #24066