-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/translate watcher(part_3) #24066
Feature/translate watcher(part_3) #24066
Conversation
second merge
x-pack/plugins/watcher/public/components/index_select/index_select.html
Outdated
Show resolved
Hide resolved
retest |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix some more small comments.
x-pack/plugins/watcher/public/components/action_type_select/action_type_select.html
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/public/components/index_select/index_select.html
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/public/components/index_select/index_select.html
Outdated
Show resolved
Hide resolved
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
💔 Build Failed |
retest |
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a couple of issues.
x-pack/plugins/watcher/server/lib/check_license/check_license.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/watcher/server/lib/check_license/check_license.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* translate watcher(part_3) * fix default message in monitoring_watch.js * fix issues * fix issues * fix issues * fix issues
translate watcher(part_3)