Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/translate watcher(part_3) #24066

Merged
merged 18 commits into from
Oct 19, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Oct 16, 2018

translate watcher(part_3)

@Nox911
Copy link
Contributor Author

Nox911 commented Oct 17, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix some more small comments.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@maryia-lapata
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple of issues.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryia-lapata maryia-lapata merged commit a5c28d5 into elastic:master Oct 19, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Oct 19, 2018
* translate watcher(part_3)

* fix default message in monitoring_watch.js

* fix issues

* fix issues

* fix issues

* fix issues
maryia-lapata added a commit that referenced this pull request Oct 19, 2018
* translate watcher(part_3)

* fix default message in monitoring_watch.js

* fix issues

* fix issues

* fix issues

* fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants