Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More add data icons #24026

Merged
merged 1 commit into from
Oct 16, 2018
Merged

More add data icons #24026

merged 1 commit into from
Oct 16, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Oct 15, 2018

Summary

Fix #24019

Adds more icons now available in EUI to the add data tutorials.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Copy link

@alexfrancoeur alexfrancoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful, thanks @timroes!

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Oct 15, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeelmers
Copy link
Member

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timroes Thanks for the quick turnaround 🎉

@ruflin
Copy link
Member

ruflin commented Oct 16, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 9fb63d1 into elastic:master Oct 16, 2018
@timroes timroes deleted the add-data-icons branch October 16, 2018 08:40
timroes added a commit to timroes/kibana that referenced this pull request Oct 17, 2018
timroes added a commit that referenced this pull request Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants