Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] WithCapabilities container #24067

Closed
wants to merge 3 commits into from

Conversation

skh
Copy link
Contributor

@skh skh commented Oct 16, 2018

Implements #23572

To test this, you need a node of which you know that it doesn't report data which is needed for a layout. Either:

  • look at e.g. demo-stack-apache-01 which doesn't report Kubernetes metrics. The Kubernetes section on the metrics page shouldn't be visible.
  • Edit one of the layout definitions in public/pages/metrics/layouts to only require impossible capabilities for one section, e.g. change requires: ['system.cpu'] to requires: ['XXX.cpu']. The corresponding section should no longer be visible on the metrics page that uses that layouts definition.

@skh skh added the Feature:Metrics UI Metrics UI feature label Oct 16, 2018
@skh
Copy link
Contributor Author

skh commented Oct 16, 2018

I had trouble with rebasing and want to keep this branch as it is. Will open a new PR.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alvarolobato alvarolobato added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants