Migrate visualization controls to use references #30880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
reviewed
Feb 12, 2019
spalger
reviewed
Feb 12, 2019
.../core_plugins/kibana/public/visualize/saved_visualizations/saved_visualization_references.js
Outdated
Show resolved
Hide resolved
.../core_plugins/kibana/public/visualize/saved_visualizations/saved_visualization_references.js
Outdated
Show resolved
Hide resolved
mikecote
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
…visualization-controls-ids
💔 Build Failed |
…visualization-controls-ids
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Feb 15, 2019
* Migrate visualization controls to use references * Apply PR feedback
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Feb 15, 2019
* Migrate visualization controls to use references * Apply PR feedback
mikecote
added a commit
that referenced
this pull request
Feb 15, 2019
mikecote
added a commit
that referenced
this pull request
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves visualization portion of #30455.
This PR moves index pattern ids in controls over to references. (Path
attributes.visState.params.controls[x].indexPattern). This should have been done in #28199 but was missed until I analyzed flights sample data in the system.