Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB flashes a chart upon clicking create #30946

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 13, 2019

Summary

Fix #30839, #30942

Before:
2

After:
1

@alexwizp
Copy link
Contributor Author

WIP - not sure that this is a good solution.

@alexwizp alexwizp changed the title TSVB flashes a chart upon clicking create [WIP] TSVB flashes a chart upon clicking create Feb 13, 2019
@Crazybus
Copy link

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alexwizp
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp changed the title [WIP] TSVB flashes a chart upon clicking create TSVB flashes a chart upon clicking create Feb 20, 2019
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally and works.

@alexwizp alexwizp added v7.0.0 v8.0.0 v6.7.1 Feature:TSVB TSVB (Time Series Visual Builder) v6.7.0 v7.2.0 and removed v6.7.1 labels Feb 20, 2019
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexwizp alexwizp merged commit 696f63c into elastic:master Feb 20, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp added a commit that referenced this pull request Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp added a commit that referenced this pull request Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp added a commit that referenced this pull request Feb 20, 2019
* TSVB flashes a chart upon clicking create
@alexwizp alexwizp deleted the 30839 branch January 4, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants