-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSVB flashes a chart upon clicking create #30946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - not sure that this is a good solution. |
alexwizp
changed the title
TSVB flashes a chart upon clicking create
[WIP] TSVB flashes a chart upon clicking create
Feb 13, 2019
retest |
💚 Build Succeeded |
💔 Build Failed |
retest |
💔 Build Failed |
💚 Build Succeeded |
alexwizp
changed the title
[WIP] TSVB flashes a chart upon clicking create
TSVB flashes a chart upon clicking create
Feb 20, 2019
markov00
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested locally and works.
alexwizp
added
v7.0.0
v8.0.0
v6.7.1
Feature:TSVB
TSVB (Time Series Visual Builder)
v6.7.0
v7.2.0
and removed
v6.7.1
labels
Feb 20, 2019
sulemanof
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 20, 2019
* TSVB flashes a chart upon clicking create
alexwizp
added a commit
that referenced
this pull request
Feb 20, 2019
alexwizp
added a commit
that referenced
this pull request
Feb 20, 2019
alexwizp
added a commit
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #30839, #30942
Before:
After: