correctly passing saved filters and query to all response handlers #32749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lukeelmers
reviewed
Mar 9, 2019
There was a problem hiding this comment.
Tested with new pipeline and everything works. I noticed that we weren't excluding disabled saved filters, so I pushed an update for that.
Ideally I'd like to do a functional test for this too; I started looking into it, but there's very little in place so far for vega. I'll try to find time to add this if possible.
💔 Build Failed |
lukeelmers
force-pushed
the
fix/vegaContext
branch
from
e00c184 to
116763a
Compare
lukeelmers
approved these changes
Mar 11, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
|
seems a related test is failing: |
lukeelmers
force-pushed
the
fix/vegaContext
branch
from
116763a to
dd101c2
Compare
|
@ppisljar Yeah that was the test that I added -- cross-browser rendering differences make screenshot comparison in functional tests hard to do. I tried a different approach that hopefully will work this time around. |
💚 Build Succeeded |
|
retest (just to be safe) |
lukeelmers
approved these changes
Mar 11, 2019
💚 Build Succeeded |
ppisljar
added
review
v7.0.0
Feature:ExpressionLanguage
|
Pinging @elastic/kibana-app |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Mar 12, 2019
ppisljar
added a commit
that referenced
this pull request
Mar 12, 2019
ppisljar
added a commit
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #29836
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)[ ] This includes a feature addition or change that requires a release note and was labeled appropriately