Ensure saved filters from searchSource are always passed to response handlers #33074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
^ errors all monitoring related. I think a rebase on master should fix these |
lukeelmers
force-pushed
the
fix/vega-context
branch
from
0c9c89e to
29ca0b2
Compare
💚 Build Succeeded |
This was referenced Mar 13, 2019
lukeelmers
added
Feature:Vega
|
Pinging @elastic/kibana-app |
|
Looks like this also resolves #31060. |
lukeelmers
changed the title
|
Would it be possible to get the fix for #31060 back to 6.x? |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Mar 14, 2019
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Mar 14, 2019
lukeelmers
added a commit
that referenced
this pull request
Mar 14, 2019
lukeelmers
added a commit
that referenced
this pull request
Mar 14, 2019
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Mar 15, 2019
lukeelmers
added a commit
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29836
#32749 was reverted due to a flaky functional test being introduced. The re-opens the same PR with the flaky test skipped.
We will track work to fix the flaky test separately: #33187