Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pause button to the header when auto-refresh is enabled #3800

Merged
merged 10 commits into from
May 15, 2015

Conversation

rashidkpc
Copy link
Contributor

This could in theory go into 4.1.0, but shouldn't block release, so I've added 4.2.0 to it

This adds a refresh button to the timepicker toggle of the navbar whenever auto-refresh is enabled. It:

  • Should not fetch when clicking pause
  • Should fetch when clicking play
  • Should stop auto refresh while paused
  • Show the play button while paused
  • Should restart auto refresh with the same interval when played
  • Show the pause button while playing

screen shot 2015-05-08 at 3 58 58 pm

Closes #3498

@spalger
Copy link
Contributor

spalger commented May 9, 2015

Hmm... now I see what you mean about clicking the refresh interval button.

Code and functionality looks great!

@spalger
Copy link
Contributor

spalger commented May 9, 2015

Oh, and in case you didn't notice I took a stab at the tab switching and submit a PR against your fork.

Open the timepicker to a specific tab
@rashidkpc rashidkpc assigned lukasolson and BigFunger and unassigned spalger and lukasolson May 11, 2015
@rashidkpc rashidkpc force-pushed the feature/pause-button branch from 641f121 to b7ff112 Compare May 11, 2015 21:07
@w33ble
Copy link
Contributor

w33ble commented May 11, 2015

I know this has been discussed at length, but I'm not sure where the discussion ended. Just wanted to chime in - this is how I use the timepicker, and now it doesn't work like I expect anymore (it doesn't close).

2015-05-11 16_00_28

@w33ble
Copy link
Contributor

w33ble commented May 11, 2015

I noticed that when you remove the refresh and add it back, it is added in "paused" mode. Is this intentional?

2015-05-11 16_04_06

@BigFunger BigFunger assigned rashidkpc and unassigned BigFunger May 13, 2015
@rashidkpc
Copy link
Contributor Author

Ok, fixed the pausing when disable/re-enable thing. I also tweaked the way tabs work:

Header in the new scenario:

  • timepicker closed, refresh enabled: Show refresh interval, clicking it will open timepicker on refresh tab
  • timepicker open, refresh enabled: Show refresh interval, clicking it will switch to refresh tab
  • timepicker closed, refresh disabled: No autorefresh display, clicking time will open time picker
  • timepicker open, refresh disabled: "Auto refresh" button shown, clicking it will switch to auto refresh display

I also got rid of the tabs in the dialog and added an arrow to indicate which tab was selected

screen shot 2015-05-14 at 12 43 15 pm

@rashidkpc rashidkpc assigned BigFunger and unassigned rashidkpc May 14, 2015
@rashidkpc rashidkpc added v4.1.0 and removed v4.2.0 labels May 14, 2015
@BigFunger
Copy link
Contributor

There is an issue with visual artifacts when clicking on the legacy minimize button at the bottom of the roll out section instead of clicking again on the button at the top.
collapse artifact

Also, if you modify the data range by clicking and dragging in the visualization area while the refresh is paused, the system does not update to the newly selected range.

@BigFunger BigFunger assigned rashidkpc and unassigned BigFunger May 15, 2015
@rashidkpc rashidkpc assigned BigFunger and unassigned rashidkpc May 15, 2015
BigFunger added a commit that referenced this pull request May 15, 2015
Add a pause button to the header when auto-refresh is enabled
@BigFunger BigFunger merged commit 6d48f73 into elastic:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause button for auto refresh
5 participants