Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved modal and transition directives to ML #39976

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Moved modal and transition directives to ML #39976

merged 4 commits into from
Jul 1, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jun 30, 2019 •
edited
Loading

Summary

Moved directives used only by ML into ML:

  • modal directive
  • transition directive
  • paginated_selectable_list

Please note that there are some console errors in ML on master (and they happen on my branch as well)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@lizozom lizozom added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Jun 30, 2019
@lizozom lizozom requested a review from a team as a code owner June 30, 2019 11:40
@lizozom lizozom self-assigned this Jun 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@stacey-gammon stacey-gammon mentioned this pull request Jun 30, 2019
Closed
94 tasks
@lukeelmers lukeelmers mentioned this pull request Jun 30, 2019
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

peteharverson
peteharverson approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note AFAIK the modal directive is now only used in the detector modal of the Advanced job wizard, so this should all be removed once the advanced wizard has been converted to React.

@lizozom lizozom merged commit 1824d99 into elastic:master Jul 1, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Jul 1, 2019
Moved modal and transition directives to ML (elastic#39976)
45f2ac6 
* Moved modal and transition directives to ML

* Moved paginated selectable list to ML

* Moved paginated selectable list test

* Fixed i18n
@lizozom lizozom mentioned this pull request Jul 1, 2019
Merged
lizozom pushed a commit that referenced this pull request Jul 1, 2019
Moved modal and transition directives to ML (#39976) (#40013)
2cbf5ac 
* Moved modal and transition directives to ML

* Moved paginated selectable list to ML

* Moved paginated selectable list test

* Fixed i18n
@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Jul 17, 2019
@lukeelmers lukeelmers mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@lizozom lizozom

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizozom @elasticmachine @peteharverson