Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Architecture roadmap for New Platform migration #31968

Closed
lukeelmers opened this issue Feb 25, 2019 · 4 comments
Closed

App Architecture roadmap for New Platform migration #31968

lukeelmers opened this issue Feb 25, 2019 · 4 comments

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Feb 25, 2019

This tracks work for migrating all areas owned by App Architecture team to the New Platform.

Phase I: Move 📦

Shimming and moving code from ui/public and legacy plugins into shims.

7.2

Prep Work

ui/public modules

Legacy Plugins

7.3

Prep Work

ui/public modules

Legacy Plugins

7.4

ui/public modules

Legacy Plugins

7.5

ui/public modules

Legacy Plugins

7.6

ui/public modules

7.7

ui/public modules

  • management -> advanced settings -> settings

7.x

Phase II: Refactor 🛠

Rewiring stateful dependencies, de-Angularizing, Jestifying, TypeScriptifying, NP-readyfying.

Phase III: Cutover 🎉

Moving a plugin from the legacy world to the New Platform—it's when code has moved out of src/legacy and into src/plugins.

AppArch Plugins

  • bfetch
  • data
    • data.indexPatterns
    • data.filter
    • data.query
    • data.timefilter
    • data.ui
    • data.search
      • aggs legacy API removal
  • dashboard_embeddable_container
  • embeddable
  • expressions
  • inspector
  • management
  • navigation
  • kibana_react
  • kibana_utils
  • ui_actions
  • visualizations
  • x-pack: advanced_ui_actions
  • x-pack: data_enhanced (includes kuery autocomplete)

Other items that need to happen before 8.0


Resources

@lukeelmers lukeelmers added Meta Feature:New Platform Team:Visualizations Visualization editors, elastic-charts and infrastructure :AppArch labels Feb 25, 2019
@epixa
Copy link
Contributor

epixa commented Feb 25, 2019

If you’re splitting plugins, I recommend splitting oss_telemetry to visualize_telemetry, dashboard_telemetry, etc. as appropriate.

@lukeelmers lukeelmers changed the title Kibana App preparation for New Platform migration Kibana App roadmap for New Platform migration Feb 28, 2019
@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2019
@lizozom
Copy link
Contributor

lizozom commented Jun 18, 2019

@elastic/kibana-app-arch we were long discussing where to move kbn_top_nav.

What is it?

kbn_top_nav is a UI component has the following features:

  • Displaying the top menu (New, Edit, Help menus etc)
  • Extending said menu with custom items using a registry (currently NavBarExtensionsRegistryProvider)
  • It currently has an element that can be used to display a inline piece of UI. This option is being used only by DevTools, and these custom pieces should be moved to a flyout and this capability deprecated (@AlonaNadler, @elastic/eui-design )
  • Supports adding additional content using $transclude. This is being used to inject things like
    • SearchBar
    • QueryBar
    • Timepicker
    • etc.

Where should it go?

I would like to suggest that kbn_top_nav is a react helper for apps and app developers to create and enrich menus. As such, I believe the new platform implementation should reside in the kibana-react plugin.

@cchaos
Copy link
Contributor

cchaos commented Jun 18, 2019

The @elastic/kibana-design team's thoughts around that top menu is to remove it altogether as a component that plugins must extend. We're seeing more and more that each application is using their own style of "menu bar" – for good reason as most plugins are unique.

Instead, what we should provide is more of an established pattern and/or component in EUI. This way, they should all look and behave the same but don't rely on a heavily dictated service within Kibana. The design team can add this to our roadmap for 7.4 as something that should be thought out.

You're welcome to move all those current services to where appropriate but I probably wouldn't put effort into expanding the capabilities.

@streamich
Copy link
Contributor

@streamich streamich changed the title Kibana App roadmap for New Platform migration App Architecture roadmap for New Platform migration Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants