Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Platform Migration Phase I]: convert timelion. Migrate server part #43197

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 13, 2019

Partually fix: #41667

Summary

First step of migrating to the new Platform. In this PR was migrated only server part of timelion plugin

What was done in this PR:

  • Have a new platform-style server plugin definition in typescript, with a setup method returning the public contract (see data plugin as an example). This needs to be exported from the top-level /server and/or /public directory, e.g. export foo = new Plugin.setup()
  • Removed init.js file. Logic was refactored and was moved to plugin.ts
  • Use server.expose instead of unsafe:
 server.plugins.timelion = {
    functions: functions,
    addFunction: addFunction,
    getFunction: getFunction
  };

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elastic elastic deleted a comment from elasticmachine Aug 14, 2019
@elastic elastic deleted a comment from elasticmachine Aug 14, 2019
@alexwizp alexwizp marked this pull request as ready for review August 14, 2019 11:21
@alexwizp alexwizp added Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0 Team:AppArch labels Aug 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code overall LGTM, tested Chrome OSX and not finding any issues.


[*.md]
trim_trailing_whitespace = false
insert_final_newline = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we had an old .editorconfig in here!

@alexwizp alexwizp merged commit 95011fb into elastic:master Aug 16, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 16, 2019
…on - add server plugin (elastic#43197)

# Conflicts:
#	src/legacy/core_plugins/timelion/index.js
alexwizp added a commit that referenced this pull request Aug 16, 2019
…on - add server plugin (#43197) (#43437)

# Conflicts:
#	src/legacy/core_plugins/timelion/index.js
@alexwizp alexwizp deleted the timelion_step1 branch January 4, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Platform Migration Phase I]: convert timelion to vis_type_timelion
3 participants