-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Platform Migration Phase I]: convert timelion. Migrate server part #43197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
force-pushed
the
timelion_step1
branch
from
August 14, 2019 10:04
84b03dc
to
af62cdd
Compare
…on - add server plugin
alexwizp
force-pushed
the
timelion_step1
branch
from
August 14, 2019 11:13
af62cdd
to
258132b
Compare
alexwizp
added
Feature:Timelion
Timelion app and visualization
release_note:skip
Skip the PR/issue when compiling release notes
v7.4.0
v8.0.0
Team:AppArch
labels
Aug 14, 2019
Pinging @elastic/kibana-app-arch |
💚 Build Succeeded |
lukeelmers
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code overall LGTM, tested Chrome OSX and not finding any issues.
|
||
[*.md] | ||
trim_trailing_whitespace = false | ||
insert_final_newline = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize we had an old .editorconfig
in here!
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Aug 16, 2019
…on - add server plugin (elastic#43197) # Conflicts: # src/legacy/core_plugins/timelion/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:NP Migration
Feature:Timelion
Timelion app and visualization
release_note:skip
Skip the PR/issue when compiling release notes
v7.4.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partually fix: #41667
Summary
First step of migrating to the new Platform. In this PR was migrated only server part of
timelion
pluginWhat was done in this PR:
init.js
file. Logic was refactored and was moved toplugin.ts
server.expose
instead of unsafe:Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers