[NP] Timelion #44039
Merged
[NP] Timelion #44039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
💚 Build Succeeded |
alexwizp
reviewed
Aug 28, 2019
alexwizp
reviewed
Aug 28, 2019
src/legacy/core_plugins/timelion/public/panels/timechart/timechart.js
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Aug 28, 2019
alexwizp
reviewed
Aug 28, 2019
💚 Build Succeeded |
gospodarsky
requested review from
ppisljar,
lukeelmers,
timroes,
markov00 and
streamich
|
retest |
💚 Build Succeeded |
lukeelmers
reviewed
Aug 29, 2019
src/legacy/core_plugins/timelion/public/panels/timechart/timechart.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
alexwizp
reviewed
Sep 24, 2019
alexwizp
reviewed
Sep 24, 2019
alexwizp
reviewed
Sep 24, 2019
💔 Build Failed |
alexwizp
approved these changes
Sep 24, 2019
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
ppisljar
requested changes
Sep 25, 2019
src/legacy/core_plugins/timelion/public/shim/legacy_dependencies_plugin.ts
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/timelion/public/vis/timelion_request_handler.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
This was referenced Sep 27, 2019
gospodarsky
pushed a commit
that referenced
this pull request
Sep 27, 2019
* Move index.js to index.ts * Migrate Vis, interpreter, home and 2 hacks to setup() and start() * Move Timechart hack to start() * Add featureCatalogueRegistryProvider to an interface * Add types to a server param * Move some .js to .ts * Add ExpressionFunction<> to interpreter * Remove Feature Provider * Remove extra export * Add an interface to a timelion response * Add an inteface to the panel * Add IPrivate interface * Make nit notes * Edit uiCapabilities() type * Shim Timelion plugin * Shim start() plugin method * Change InternalCoreStart to LegacyCoreStart * Move Angular dependencies to a separate module * Change visualizations import path due to recent changes * Rename directives * Take a common property out * Get rid of require in schema * Use core.uiSettings * Refactor timelion request handler * Remove Private from tests * Remove redundant dependencies from tests * Update visualizations paths * Change expressions paths due to expessions movement * Refactoring according to reviews * Add a comment over the uiCapabilities field * Edit the comment * Ignore uiCapabilities issue * Take angular controller out * Get rid of * Get rid of config * Get rid of config in start * Unwrap handler from redundant promise * Move npSetup npStart dependencies in a high level * Rename some details * Fix reviews * fix CI * Take visFactory out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #31968
Shim
Timelionplugin to NP.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers