Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved fancy forms into vis editor #39977

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Moved fancy forms into vis editor #39977

merged 1 commit into from
Jul 1, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jun 30, 2019

Summary

Moved fancy forms into vis editor.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@lizozom lizozom added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 Team:AppArch v7.3.0 labels Jun 30, 2019
@lizozom lizozom self-assigned this Jun 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom lizozom requested review from streamich and lukeelmers June 30, 2019 11:49
@stacey-gammon stacey-gammon mentioned this pull request Jun 30, 2019
Closed
94 tasks
@lizozom
Copy link
Contributor Author

lizozom commented Jun 30, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukeelmers lukeelmers mentioned this pull request Jun 30, 2019
Closed
ppisljar
ppisljar approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@lizozom lizozom merged commit 09950ea into elastic:master Jul 1, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Jul 1, 2019
Moved fancy forms into vis editor (elastic#39977)
ff23949
@lizozom lizozom mentioned this pull request Jul 1, 2019
Merged
lizozom pushed a commit that referenced this pull request Jul 1, 2019
Moved fancy forms into vis editor (#39977) (#39994)
819350b
@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Jul 17, 2019
@lukeelmers lukeelmers mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@streamich streamich Awaiting requested review from streamich

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees

@lizozom lizozom

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizozom @elasticmachine @ppisljar