[APM] Add support for very high durations (minutes and hours)

[bartvanremortele]

Summary

Fixes #41566
Adds time formatting support for high duration transactions.
Formatting will be moved up to minutes if the transaction took longer than 1 minute and to hours if it took longer than 1 hour.

i18n for JPN was done using google, I do not speak Japanese.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[sorenlouv]

retest

[sorenlouv]

Hi @bartvanremortele,
Thanks for your contribution. Overall it looks great 👍

[sorenlouv]

The transaction files are auto-generated so if you created this and the Japanese by hand you can just discard them again.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[sorenlouv]

@bartvanremortele Whenever you have time please rebase this with master so I can merge. Thanks again for the contribution!

[bartvanremortele]

@sqren Done! I would love to contribute more but it's hard to identify which issues I'm able to pick up. Do you have a mentorship program or a platform to onboard contributers?

[bartvanremortele]

Hmm I ran node scripts/update_prs 41640 assuming it would rebase but it merged master into the PR branch.

[bartvanremortele]

Fixed! :-)

[sorenlouv]

@katrin-freihofner @dgieselaar Do you have any opinions on whether the display value for hours should be "hours", "hrs" or "h". Same with minutes. Currently we abbreviate seconds to "s", millis to "ms" and micros to "μs".

Hours

Minutes

[sorenlouv]

@bartvanremortele I'll just get my colleagues opinion on the unit abbreviation, and then I'll merge it.

Done! I would love to contribute more but it's hard to identify which issues I'm able to pick up. Do you have a mentorship program or a platform to onboard contributers?

We try to apply the label "good first issue" to make it easier for the community to help out - but you probably know that since you found this one :)
We don't have a mentorship program AFAIK but I'll bring it up in the next team meeting (next week) and see what we can do.

[dgieselaar]

I think h/d makes sense here.

…

On Thu, Jul 25, 2019, 18:12 Søren Louv-Jansen ***@***.***> wrote: @katrin-freihofner <https://github.com/katrin-freihofner> @dgieselaar <https://github.com/dgieselaar> Do you have any opinions on whether the display value for hours should be "hours", "hrs" or "h". Same with minutes. Currently we abbreviate seconds to "s", millis to "ms" and micros to "μs". *Hours* [image: Screen Shot 2019-07-25 at 18 07 18] <https://user-images.githubusercontent.com/209966/61890251-5fe53700-af07-11e9-9973-759e7284d647.png> *Minutes* [image: Screen Shot 2019-07-25 at 18 06 55] <https://user-images.githubusercontent.com/209966/61890252-5fe53700-af07-11e9-80ea-c7f213e8104f.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41640?email_source=notifications&email_token=AACWDXGNU5VRT5TBSMWR7NTQBHGIHA5CNFSM4IFSSNV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Z6UEA#issuecomment-515107344>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACWDXCPDCRC46NPTOADOUDQBHGIHANCNFSM4IFSSNVQ> .

[katrin-freihofner]

I would suggest to use
ms...milliseconds
s...seconds
min...minutes
h...hours

but as long as it is not m (like meters) for minutes I'm fine :) Thanks everyone!

[katrin-freihofner]

...sorry, closing this was a mistake.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[sorenlouv]

As suggested by @katrin-freihofner minutes should be abbreviated "min"

[sorenlouv]

retest

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[sorenlouv]

@bartvanremortele I rebased your branch with master - hopefully that'll fix the build errors.

[sorenlouv]

retest

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[sorenlouv]

@bartvanremortele This needs to be backported to "7.x" which is the release branch for 7.4, 7.5 and all other future releases on 7.

I can do it for you but if you are interested in doing it yourself I can help out. Basically you just need to cherry-pick 7ff85c4 from master and create a PR towards 7.x branch.

This is boring work, so we use a backport tool. If you already have cloned kibana you don't need to install the backport tool again, but can simply run yarn backport (inside the kibana folder). It will probably complain about missing github credentials in {homefolder}/.backport/config.json.

Follow these steps to fill out the config.json: https://github.com/sqren/backport/blob/master/docs/configuration.md#global-config-backportconfigjson

[bartvanremortele]

@sqren I will gladly do this. Thanks for giving me the opportunity.