[Maps] Add support for date fields in dynamic styles #47903
Conversation
…kibana into dynamic-style-time
nickpeihl
added
release_note:enhancement
Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
| }); | ||
|
|
||
| return [...numberFieldOptions, ...joinFields]; | ||
| return [...timeFieldOptions, ...numberFieldOptions, ...joinFields]; |
There was a problem hiding this comment.
Would this list time fields list before number fields in the UI? (Or is there something else sorting them later?) 🤔
There was a problem hiding this comment.
The list in the dropdown appears to be alphabetical by field label.
|
Love this feature and think it will be really useful! |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
I get the follow console errors when I create a grid aggregation layer or EMS boundaries layer and add it to the map. AbstractSource may need a default implementation of getTimeFields
|
💚 Build Succeeded |
| const { supportsFeatureState, isScaled, name, range, computedName } = styleFields[j]; | ||
| const value = parseFloat(feature.properties[name]); | ||
| //Date fields pulled from doc_values is an array of epoch_millis and a date string | ||
| const value = Array.isArray(feature.properties[name]) |
There was a problem hiding this comment.
Can you move the logic for extracting date fields out of VectorStyle which is generic and should not have source specific details. You can put the logic into hitsToGeoJson
| const initialSearchContext = { | ||
| docvalue_fields: searchFilters.fieldNames | ||
| }; | ||
| initialSearchContext.docvalue_fields.push(...searchFilters.fieldNames); |
There was a problem hiding this comment.
The time field is getting included in docvalue_fields twice. Below is an example request. To prevent this, filter searchFilters.fieldNames to exclude time fields since they are already in docvalue_fields.
"docvalue_fields": [
{
"field": "@timestamp",
"format": "epoch_millis"
},
"@timestamp",
"geo.coordinates"
],
|
Looks like the legend is showing a raw timestamp when styling by date?
|
💚 Build Succeeded |
|
Currently this allows you to link symbol orientation to a date field (anecdotally it seems all icons are oriented at 0 degrees though). Unless we have a clear rationale for mapping date to orientation (🤔?), we may want to exclude dates there. |
💔 Build Failed |
use new Fields syntax, simplify docvalue_fields creation
💚 Build Succeeded |
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review, tested in chrome
* [Maps] retrieve geo_point value from docvalue_fields instead of _source * [Maps] retrieve geo_point value from docvalue_fields instead of _source * Dynamically style by time field * Add epoch_millis to date fields in docvalues * add functional test ensuring _search request only pulls what is needed * Add functional test for dynamic styles by date field * Support dynamic styles in top hits agg * Add getTimeFields fn to vector_source * Retrieve only epoch_millis for date fields in docvalues * use new Fields syntax, simplify docvalue_fields creation * fix comment
|
7.x #48295 |
|
💥💥💥 |
* [Maps] retrieve geo_point value from docvalue_fields instead of _source * [Maps] retrieve geo_point value from docvalue_fields instead of _source * Dynamically style by time field * Add epoch_millis to date fields in docvalues * add functional test ensuring _search request only pulls what is needed * Add functional test for dynamic styles by date field * Support dynamic styles in top hits agg * Add getTimeFields fn to vector_source * Retrieve only epoch_millis for date fields in docvalues * use new Fields syntax, simplify docvalue_fields creation * fix comment
4 participants
Summary
Fixes #39219. This adds date fields to the supported fields for dynamic styles in the maps app.
For example, this screenshot shows the most recent five locations of an airplane in flight. The older locations are smaller and lighter colored than more recent locations.
This builds upon the work in PR #47389. Ideally, we could merge that PR first.