Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Move sample data and feature registration to canvas np plugin #56564

Merged
merged 7 commits into from
Feb 11, 2020
Merged

[Canvas] Move sample data and feature registration to canvas np plugin #56564

merged 7 commits into from
Feb 11, 2020

Conversation

poffdeluxe
Copy link
Contributor

Summary

Moves the sample data loading and Canvas feature registration into the NP Canvas plugin

@poffdeluxe poffdeluxe added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.7.0 labels Jan 31, 2020
@poffdeluxe poffdeluxe requested a review from a team as a code owner January 31, 2020 22:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

crob611
crob611 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the question about importing vs pulling off the home plugin

x-pack/plugins/canvas/server/sample_data/load_sample_data.ts Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit 0dd8129 into elastic:master Feb 11, 2020
@poffdeluxe poffdeluxe deleted the np-sample-data-register-feature branch February 11, 2020 23:24
@poffdeluxe poffdeluxe mentioned this pull request Feb 11, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 12, 2020
@gmmorris
Merge branch 'master' into alerting/action-groups-i18n
2ac9e23 
* master:
  [Canvas] Move sample data and feature registration to canvas np plugin (elastic#56564)
  instrument task manager with apm transactions (elastic#55356)
  displays Alert Instance state on Alert Details page (elastic#56842)
  Adding the Accessibility Statement to docs (elastic#57153)
  [Uptime] Remove redundant adapter function (elastic#56980)
  [SIEM][Detection Engine] Backend end-to-end tests
  [Uptime] Added tests for pages (elastic#56736)
  Updating to kind-of@6.0.3 (elastic#57367)
poffdeluxe added a commit that referenced this pull request Feb 12, 2020
@poffdeluxe @elasticmachine
[Canvas] Move sample data and feature registration to canvas np plugin (
d52d48d 
#56564) (#57391)

* Move sample data and feature registration to canvas np plugin

* Prepare to move i18n to new platform and adjust paths

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poffdeluxe @elasticmachine @kibanamachine @crob611