Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Remove redundant adapter function #56980

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #56864.

Remove a redundant function and rename another one.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@justinkambic justinkambic added technical debt Improvement of the software architecture and operational architecture v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Feb 6, 2020
@justinkambic justinkambic self-assigned this Feb 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Feb 6, 2020
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic justinkambic force-pushed the uptime_remove-redundant-adapter-function branch from 3605ed3 to ab80dde Compare February 6, 2020 16:31
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , WFG !!

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #24939 failed 3605ed38454fda310ec564d718898af0a0cba9e1
  • 💔 Build #24921 failed 039e87d85c9c570779955da16e87816c3263c0b3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 6, 2020
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic merged commit 7f336b4 into elastic:master Feb 11, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 12, 2020
* master:
  [Canvas] Move sample data and feature registration to canvas np plugin (elastic#56564)
  instrument task manager with apm transactions (elastic#55356)
  displays Alert Instance state on Alert Details page (elastic#56842)
  Adding the Accessibility Statement to docs (elastic#57153)
  [Uptime] Remove redundant adapter function (elastic#56980)
  [SIEM][Detection Engine] Backend end-to-end tests
  [Uptime] Added tests for pages (elastic#56736)
  Updating to kind-of@6.0.3 (elastic#57367)
justinkambic added a commit to justinkambic/kibana that referenced this pull request Feb 25, 2020
* Remove get_doc_count function in favor of index status function.

* Rename adapter function.

* Remove obsolete import.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic added a commit that referenced this pull request Feb 25, 2020
* Remove get_doc_count function in favor of index status function.

* Rename adapter function.

* Remove obsolete import.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@justinkambic
Copy link
Contributor Author

Backported to:
7.x/7.7.0 d1cfe9d
#58418

@justinkambic justinkambic deleted the uptime_remove-redundant-adapter-function branch February 25, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Refactor duplicated Index Status functionality
4 participants