fixing maps #56706
Merged
fixing maps #56706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
v8.0.0
Team:AppArch
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
ppisljar
force-pushed
the
fix/mapshacks
branch
2 times, most recently
from
9847312
to
47d05b8
Compare
nreese
reviewed
Feb 4, 2020
| @@ -37,5 +37,5 @@ visualizationsSetup.types.registerAlias({ | |||
| }); | |||
|
|
|||
| if (!showMapVisualizationTypes) { | |||
| visualizationsSetup.types.hideTypes(['region_map', 'tile_map']); | |||
| //visualizationsSetup.types.hideTypes(['region_map', 'tile_map']); | |||
There was a problem hiding this comment.
this line should remain so region_map and tile_map are hidden in the create new visualization menu.
There was a problem hiding this comment.
yup, i uncommented this to help me test
lukeelmers
reviewed
Feb 4, 2020
There was a problem hiding this comment.
Code LGTM pending green CI. I think we can delete the query_geohash_bounds file as a part of this, and also close #30593
| @@ -46,7 +46,6 @@ import { | |||
| import { dispatchRenderComplete } from '../../../../../plugins/kibana_utils/public'; | |||
| import { SavedSearch } from '../../../kibana/public/discover/np_ready/types'; | |||
| import { Vis } from '../np_ready/public'; | |||
| import { queryGeohashBounds } from './query_geohash_bounds'; | |||
There was a problem hiding this comment.
Can we delete the query_geohash_bounds file then? I think this was the only place it was used.
|
@elasticmachine merge upstream |
ppisljar
force-pushed
the
fix/mapshacks
branch
from
d2698bb
to
5e7d1bd
Compare
ppisljar
commented
Feb 5, 2020
|
|
||
| const defaultPrecision = 2; | ||
| const maxPrecision = parseInt(config.get('visualization:tileMap:maxPrecision'), 10) || 12; |
There was a problem hiding this comment.
all this logic was moved inside tile_map_vis (it needs to set correct precision based on zoom level)
ppisljar
commented
Feb 5, 2020
| output.params.precision = aggConfig.params.autoPrecision | ||
| ? autoPrecisionVal | ||
| : getPrecision(aggConfig.params.precision); | ||
| output.params.precision = aggConfig.params.precision; |
There was a problem hiding this comment.
correct precision is calculated in tile_map_vis
ppisljar
commented
Feb 5, 2020
| @@ -117,17 +65,7 @@ export const geoHashBucketAgg = new BucketAggType<IBucketGeoHashGridAggConfig>({ | |||
| write: () => {}, | |||
| }, | |||
| { | |||
| name: 'mapZoom', | |||
There was a problem hiding this comment.
mapZoom and mapCenter are no longer stored on the agg config
ppisljar
commented
Feb 5, 2020
| params: { | ||
| geo_bounding_box: { | ||
| ignore_unmapped: true, | ||
| [agg.getField().name]: params.boundingBox || defaultBoundingBox, |
There was a problem hiding this comment.
if bounding box is not set we use default (which should exclude all data)
ppisljar
commented
Feb 5, 2020
| @@ -43,6 +43,10 @@ export const createTileMapFn = () => ({ | |||
| geocentroid, | |||
| }); | |||
|
|
|||
| if (geohash && geohash.accessor) { | |||
| convertedData.meta.geohash = context.columns[geohash.accessor].meta; | |||
There was a problem hiding this comment.
keep the geohash column meta information, so it can be used to construct filters
ppisljar
commented
Feb 5, 2020
| @@ -126,6 +136,14 @@ export const createTileMapVisualization = ({ serviceSettings, $injector }) => { | |||
| return; | |||
| } | |||
|
|
|||
| if ( | |||
| !this._geoJsonFeatureCollectionAndMeta || | |||
There was a problem hiding this comment.
when data is passed in and there are no results, we try to set the boundingBox
ppisljar
commented
Feb 5, 2020
| ? zoomPrecision[this.vis.getUiState().get('mapZoom')] | ||
| : getPrecision(this._kibanaMap.getGeohashPrecision()); | ||
|
|
||
| this.vis.eventsSubject.next(updateVarsObject); |
There was a problem hiding this comment.
emit an event to request to update bounds
There was a problem hiding this comment.
Thanks, code review OK, tested the visualizations.
I think there might be a bug in the coordinate maps visualizations:
It seems modifying the "precision" slider does not actual update the map after clicking update
Steps:
- Create a coordinate map viz (be sure to press update)
- uncheck the "change precision on map zoom" switch
- change the precision slider
- click update -> the map does not change
Note that the map does update correctly, if you also change another setting (e.g. toggle one of the other switches and press update -> change OK).
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_security·ts.discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loadedStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Feb 12, 2020
ppisljar
added a commit
that referenced
this pull request
Feb 13, 2020
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) [Maps] do not show border color for icon in legend when border width is zero (elastic#57501) refactors 'data-providers' tests (elastic#57474) add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929) Management Api - add to migration guide (elastic#56892) fixing maps (elastic#56706) [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) [Alerting] make actionGroup name's i18n-able (elastic#57404) fixed flaky test (elastic#57490) ... # Conflicts: # src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap # src/plugins/telemetry/public/components/telemetry_management_section.tsx
40 tasks
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
replaces two existing tile map hacks for a new one:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers