[Maps] do not show border color for icon in legend when border width is zero

[nreese]

This PR also cleans up SymbolIcon, removing componentDidUpdate in favor of requiring users to set key propsto determine when a new component instance is needed.

Before screen shots. Notice that the icon in the legend shows a border even though there is none.

After screen shots. Notice that the icon in the legend does not show a border

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[nreese]

@elasticmachine merge upstream

[kibanamachine]

💛 Build succeeded, but was flaky

• continuous-integration/kibana-ci/pull-request
• Commit: 3dd7db5
• Flaky suites:
  • xpack-kibana-ciGroup3

---

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts.Actions and Triggers app Alert Details Alert Instances renders the active alert instances

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/57426

[00:00:00]       │
[00:00:00]         └-: Actions and Triggers app
[00:00:00]           └-> "before all" hook
[00:03:38]           └-: Alert Details
[00:03:38]             └-> "before all" hook
[00:03:56]             └-: Alert Instances
[00:03:56]               └-> "before all" hook
[00:03:56]               └-> "before all" hook
[00:03:56]                 │ debg navigating to triggersActions url: http://localhost:6141/app/kibana#/management/kibana/triggersActions
[00:03:56]                 │ debg Navigate to: http://localhost:6141/app/kibana#/management/kibana/triggersActions
[00:03:56]                 │ debg ... sleep(700) start
[00:03:56]                 │ debg browser[INFO] http://localhost:6141/app/kibana?_t=1581561524757#/management/kibana/triggersActions 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:56]                 │
[00:03:56]                 │ debg browser[INFO] http://localhost:6141/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:57]                 │ debg ... sleep(700) end
[00:03:57]                 │ debg returned from get, calling refresh
[00:03:57]                 │ debg browser[INFO] http://localhost:6141/app/kibana?_t=1581561524757#/management/kibana/triggersActions 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:57]                 │
[00:03:57]                 │ debg browser[INFO] http://localhost:6141/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:57]                 │ debg currentUrl = http://localhost:6141/app/kibana#/management/kibana/triggersActions
[00:03:57]                 │          appUrl = http://localhost:6141/app/kibana#/management/kibana/triggersActions
[00:03:57]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:00]                 │ debg TestSubjects.find(kibanaChrome)
[00:04:00]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:04:00]                 │ debg browser[INFO] http://localhost:6141/built_assets/dlls/vendors_3.bundle.dll.js 582:139970 "INFO: 2020-02-13T02:38:47Z
[00:04:00]                 │        Adding connection to http://localhost:6141/elasticsearch
[00:04:00]                 │
[00:04:00]                 │      "
[00:04:00]                 │ debg ... sleep(501) start
[00:04:01]                 │ debg ... sleep(501) end
[00:04:01]                 │ debg in navigateTo url = http://localhost:6141/app/kibana#/management/kibana/triggersActions/alerts
[00:04:01]                 │ debg TestSubjects.exists(statusPageContainer)
[00:04:01]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:04:03]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:04:04]                 │ debg creating action server-log-9282836d-821b-4369-b887-aaec8cc52774-0
[00:04:04]                 │ debg creating action server-log-9282836d-821b-4369-b887-aaec8cc52774-1
[00:04:04]                 │ debg created action 3608aba1-c701-4f63-844a-f139f9dc3d40
[00:04:04]                 │ debg created action 9896837a-4eea-4d20-aba8-ca015f0cd4b7
[00:04:04]                 │ debg creating alert test-alert-9282836d-821b-4369-b887-aaec8cc52774
[00:04:06]                 │ debg created alert 0cd50efc-9596-4494-8451-116d696fee93
[00:04:07]                 │ debg isGlobalLoadingIndicatorVisible
[00:04:07]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:04:07]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:04:07]                 │ debg browser[INFO] http://localhost:6141/app/kibana?_t=1581561524757#/management/kibana/triggersActions/alerts 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:07]                 │
[00:04:07]                 │ debg browser[INFO] http://localhost:6141/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:08]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:04:09]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:04:09]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:04:09]                 │ proc [kibana]   log   [02:38:57.378] [warning][actions][actions][plugins] Server log: from alert 1s
[00:04:09]                 │ proc [kibana]   log   [02:38:57.384] [warning][actions][actions][plugins] Server log: from alert 1s
[00:04:09]                 │ proc [kibana]   log   [02:38:57.388] [warning][actions][actions][plugins] Server log: from alert 1s
[00:04:09]                 │ proc [kibana]   log   [02:38:57.444] [warning][actions][actions][plugins] Server log: from alert 1s
[00:04:09]                 │ proc [kibana]   log   [02:38:57.453] [warning][actions][actions][plugins] Server log: from alert 1s
[00:04:09]                 │ proc [kibana]   log   [02:38:57.458] [warning][actions][actions][plugins] Server log: from alert 1s
[00:04:10]                 │ debg browser[INFO] http://localhost:6141/built_assets/dlls/vendors_3.bundle.dll.js 582:139970 "INFO: 2020-02-13T02:38:57Z
[00:04:10]                 │        Adding connection to http://localhost:6141/elasticsearch
[00:04:10]                 │
[00:04:10]                 │      "
[00:04:10]                 │ debg TestSubjects.exists(alertsList)
[00:04:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="alertsList"]') with timeout=120000
[00:04:10]                 │ debg TestSubjects.find(alertSearchField)
[00:04:10]                 │ debg Find.findByCssSelector('[data-test-subj="alertSearchField"]') with timeout=10000
[00:04:11]                 │ debg Find.findByCssSelector('.euiBasicTable[data-test-subj="alertsList"]:not(.euiBasicTable-loading)') with timeout=10000
[00:04:11]                 │ debg Find.clickDisplayedByCssSelector('[data-test-subj="alertsList"] [title="test-alert-9282836d-821b-4369-b887-aaec8cc52774"]') with timeout=10000
[00:04:11]                 │ debg Find.displayedByCssSelector([data-test-subj="alertsList"] [title="test-alert-9282836d-821b-4369-b887-aaec8cc52774"])
[00:04:11]                 │ debg Find.findByCssSelector('[data-test-subj="alertsList"] [title="test-alert-9282836d-821b-4369-b887-aaec8cc52774"]') with timeout=10000
[00:04:11]                 │ debg Wait for element become visible: [data-test-subj="alertsList"] [title="test-alert-9282836d-821b-4369-b887-aaec8cc52774"] with timeout=10000
[00:04:11]                 │ debg getting alert 0cd50efc-9596-4494-8451-116d696fee93 state
[00:04:11]               └-> renders the active alert instances
[00:04:11]                 └-> "before each" hook: global before each
[00:04:11]                 │ debg TestSubjects.exists(alertInstancesList)
[00:04:11]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="alertInstancesList"]') with timeout=120000
[00:04:11]                 │ debg getting alert 0cd50efc-9596-4494-8451-116d696fee93 state
[00:04:11]                 │ debg Find.findByCssSelector('.euiBasicTable[data-test-subj="alertInstancesList"]:not(.euiBasicTable-loading)') with timeout=10000
[00:04:12]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Actions and Triggers app Alert Details Alert Instances renders the active alert instances.png"
[00:04:12]                 │ info Current URL is: http://localhost:6141/app/kibana#/management/kibana/triggersActions/alert/0cd50efc-9596-4494-8451-116d696fee93
[00:04:12]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Actions and Triggers app Alert Details Alert Instances renders the active alert instances.html
[00:04:12]                 └- ✖ fail: "Actions and Triggers app Alert Details Alert Instances renders the active alert instances"
[00:04:12]                 │

Stack Trace

Error: expected 5000 to be below 4870
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.lessThan (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:336:8)
    at forEach (test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts:264:65)
    at Array.forEach (<anonymous>)
    at Context.it (test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts:258:12)
    at process._tickCallback (internal/process/next_tick.js:68:7)

---

History

• 💔 Build #26373 failed f9690f5
• 💔 Build #26333 failed 030e176

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jsanz]

tested for circles and icons on Chromium, nice improvement! 👌