[Maps] Move redux reducers and store logic to NP #58294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 20, 2020 16:52
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
11 tasks
kindsun
force-pushed
the
np-port-reducers-and-related-logic
branch
from
fe702cc
to
e127a90
Compare
added 14 commits
February 24, 2020 16:09
…and-related-logic
…e function for eventual init in NP
…and-related-logic
…and-related-logic
…and-related-logic # Conflicts: # x-pack/legacy/plugins/maps/public/plugin.ts # x-pack/legacy/plugins/maps/public/selectors/map_selectors.js # x-pack/legacy/plugins/maps/public/selectors/map_selectors.test.js
…and-related-logic
…and-related-logic
kindsun
added
the
release_note:skip
…and-related-logic
|
|
+1. Migrating to NP is complex enough. No reason to add TS to the mix |
nreese
reviewed
Mar 6, 2020
| @@ -4,12 +4,12 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| // @ts-nocheck | |||
There was a problem hiding this comment.
What does this do? Does it disable ts linting for the file?
There was a problem hiding this comment.
Yes. We were doing quite a few @ts-ignores and this was just cleaner. Also I needed to combine @ts-ignore and @kbn/eslint/no-restricted-paths for line 12 and couldn't find a good way to do it. I'm sure it's possible but overall this just seemed cleaner and temporary
| @@ -0,0 +1,160 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file is .ts in legacy and should stay .ts in NP.
This copy is also really stale. For example, METRIC_TYPE has been renamed AGG_TYPE and lots of values have been converted to enums for TS changes in legacy.
There was a problem hiding this comment.
Sorry yes, this was one of the first folders moved over. One thing about moving the folders over, it that you have to watch the old folders for changes. I kept reducers on my radar but let the common folder changes slip by. Thanks for catching
added 3 commits
March 6, 2020 08:37
nreese
approved these changes
Mar 6, 2020
added 5 commits
March 10, 2020 16:43
…and-related-logic
…and-related-logic
…and-related-logic
…ible. General clean up
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Mar 12, 2020
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Mar 12, 2020
* Plugin file and services in place. Some redux logic ported * Port and update index pattern util * Move reducers over to NP. Update refs in legacy * Port inspector to NP * Move some kibana services init to NP. Some cleaning * Clean up work not related to reducers/store * Ignore temp imports from NP. Clean up of changes unrelated to this PR * More cleanup. Check injected vars avab. before calling to handle dashboard case * Bind embeddables services the same way Maps app services bound. Create function for eventual init in NP * Call binding from constructor. Fix npStart plugins arg * Adapt changes from master * Register inspector views for embeddable. Add NP folder to i18n * Clean up. Add comments. Move inspector map view registration to NP * Remove unused inspector files in legacy * Move full screen action to legacy * Add in missing tooltip updates * Review feedback. Update constants and i18n_getters to latest in NP * Review feedback. Add redundancy comments to common files redundant in legacy and NP * Remove unneeded copy of parse xml string test in legacy * Review feedback. Remove redundant portions. Export from NP where possible. General clean up * Remove remaining refernce and case for 'TOUCH_LAYER'. It's never used
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 12, 2020
* master: (45 commits) skip flaky suite (elastic#59717) UI Metrics use findAll to retrieve all Saved Objects (elastic#59891) [Discover] Migrate Context mocha tests to use Jest (elastic#59658) [Maps] Move redux reducers and store logic to NP (elastic#58294) rebalance x-pack groups (elastic#58930) [Discover] Reimplement $route.reload when index pattern changes (elastic#59877) [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745) Skip CI based on changes in PR (elastic#59939) [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723) [ML] Functional tests - stabilize date_nanos test (elastic#59986) [ML] Typescripting client side endpoint functions (elastic#59928) a11y tests on adding columns to discover table (elastic#59375) fix graph plugin config path (elastic#59540) fix vega config issues (elastic#59737) [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890) [ML] Adding shared services to ml setup contract (elastic#59730) [Visualize] Fix linked search behavior (elastic#59690) [ML] Register NP ML plugin for Kibana management section. (elastic#59762) [Lens] Adds using queries/filters for field existence endpoint (elastic#59033) Delete FilterStateManager and QueryFilter :-D (elastic#59872) ...
kindsun
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Plugin file and services in place. Some redux logic ported * Port and update index pattern util * Move reducers over to NP. Update refs in legacy * Port inspector to NP * Move some kibana services init to NP. Some cleaning * Clean up work not related to reducers/store * Ignore temp imports from NP. Clean up of changes unrelated to this PR * More cleanup. Check injected vars avab. before calling to handle dashboard case * Bind embeddables services the same way Maps app services bound. Create function for eventual init in NP * Call binding from constructor. Fix npStart plugins arg * Adapt changes from master * Register inspector views for embeddable. Add NP folder to i18n * Clean up. Add comments. Move inspector map view registration to NP * Remove unused inspector files in legacy * Move full screen action to legacy * Add in missing tooltip updates * Review feedback. Update constants and i18n_getters to latest in NP * Review feedback. Add redundancy comments to common files redundant in legacy and NP * Remove unneeded copy of parse xml string test in legacy * Review feedback. Remove redundant portions. Export from NP where possible. General clean up * Remove remaining refernce and case for 'TOUCH_LAYER'. It's never used
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the following:
A few things worth noting or focusing on:
// eslint-disable-next-line @kbn/eslint/no-restricted-paths. As we continue moving the architecture over, there will continue to be more, then less, then none.kibana_services.jsfiles, one in the legacy plugin, one in the NP plugin. Eventually these will be consolidated into one, but for now we're just initializing the services (really just one in NP for now) required to support the store/reducersconstdeclarations are temporarily redundant. They're in legacy and they're in NP and they're surrounded by comments along the lines of:// NP Migration // Temporarily redundant with x-pack/plugins/maps/public/actions/map_actions.jsSince the both the reducers and the un-migrated action functions need these, the alternative is to move them and then import each of them all back to legacy, only to change it back when we're a few steps further into this migration. That just feels unnecessary but I'm open to pushbackcommonfolder are temporarily redundant as well. It's just easier that sifting through every time to figure out what's moved vs. not. In subsequent PRs these will be checked for updates (which are pretty infrequent)