-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adding shared services to ml setup contract #59730
[ML] Adding shared services to ml setup contract #59730
Conversation
Pinging @elastic/ml-ui (:ml) |
f8f15e7
to
752006a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM. Just a question about the names of the providers we are exposing.
71396fa
to
a6a2655
Compare
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/date_nanos_job·ts.machine learning anomaly detection job on data set with date_nanos time field with count detector and model plot disabled job creation enables the dedicated index switchStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
anomalyDetectorsProvider(callAsCurrentUser: APICaller) { | ||
return { | ||
jobs(jobId?: string) { | ||
isFullLicense(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this function call have a side effect like a throw
or does this need change to be part of an if
, in other files I see if (mlLicense.isFullLicense() === false) {
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [ML] Adding shared services to ml setup contract * adding data recognizer * typescripting js client * adding results service * code clean up * adding generic ml index search * making cloud optional
* master: (45 commits) skip flaky suite (elastic#59717) UI Metrics use findAll to retrieve all Saved Objects (elastic#59891) [Discover] Migrate Context mocha tests to use Jest (elastic#59658) [Maps] Move redux reducers and store logic to NP (elastic#58294) rebalance x-pack groups (elastic#58930) [Discover] Reimplement $route.reload when index pattern changes (elastic#59877) [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745) Skip CI based on changes in PR (elastic#59939) [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723) [ML] Functional tests - stabilize date_nanos test (elastic#59986) [ML] Typescripting client side endpoint functions (elastic#59928) a11y tests on adding columns to discover table (elastic#59375) fix graph plugin config path (elastic#59540) fix vega config issues (elastic#59737) [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890) [ML] Adding shared services to ml setup contract (elastic#59730) [Visualize] Fix linked search behavior (elastic#59690) [ML] Register NP ML plugin for Kibana management section. (elastic#59762) [Lens] Adds using queries/filters for field existence endpoint (elastic#59033) Delete FilterStateManager and QueryFilter :-D (elastic#59872) ...
Add access to commonly used ML endpoints via our setup contract.
External plugins which are currently calling ML endpoints can now get access to the same data via these exposed functions on the server side of kibana.
All exposed functions contain license checks and will return an error if called with the incorrect license level.
Relates to #59735
Also refactors some routes to ensure they are all consistent in the way they require
callAsCurrentUser
.Privilege checking is also required in these exposed functions, but will need to be added later once it's possible to have multiple reserved feature privileges so we can use kibana's capabilities. (#57637)