-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Histogram Data Type #59387
Support Histogram Data Type #59387
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
…reAggregatedHistogram
…reAggregatedHistogram
…low exists filters. Used that option for the Histogram data type
…reAggregatedHistogram
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
343f433
to
75e5ee1
Compare
It seems we're still showing the histogram types fields in some aggregations, that don't support it (Top Hit and Unique Count). We should disable the field for those. I suggest a snippet like: filterFieldTypes: Object.values(KBN_FIELD_TYPES).filter(
type => type !== KBN_FIELD_TYPES.HISTOGRAM
), Also we can enable the histogram field type also for the "Median" aggregation, since this is just a Kibana wrapper around the percentiles aggregation. |
…reAggregatedHistogram
…ons, and allowed histogram type to be used in the median aggregation
8422204
to
cb26162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome Linux, behaves as expected. Code LGTM.
Could you potentially create one follow-up issue, that we want to have a icon in Discover for histogram fields (should be a separate PR, since we need to have Design create an icon first).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Tested Chrome macOS & everything seems to be working as expected!
@elasticmachine merge upstream |
1 similar comment
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/management·ts.Management Create Index pattern wizardStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Added the histogram field type to Kibana, to be used in the percentiles, percentiles ranks, and median aggregations.
* master: [Uptime] Skip failing location test temporarily (elastic#60938) [ML] Disabling datafeed editing when job is running (elastic#60751) Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717) [SIEM] Add license check to ML Rule form (elastic#60691) Adding `authc.grantAPIKeyAsInternalUser` (elastic#60423) Support Histogram Data Type (elastic#59387) [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770) [SIEM] [Cases] Update case icons (elastic#60812) [TSVB] Fix percentiles band mode (elastic#60741)
* master: (26 commits) [Alerting] Fixes flaky test in Alert Instances Details page (elastic#60893) cleanup visualizations api (elastic#59958) Inline timezoneProvider function, remove ui/vis/lib/timezone (elastic#60475) [SIEM] Adds 'Open one signal' Cypress test (elastic#60484) [UA] Upgrade assistant migration meta data can become stale (elastic#60789) [Metrics Alerts] Remove metric field from doc count on backend (elastic#60679) [Uptime] Skip failing location test temporarily (elastic#60938) [ML] Disabling datafeed editing when job is running (elastic#60751) Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717) [SIEM] Add license check to ML Rule form (elastic#60691) Adding `authc.grantAPIKeyAsInternalUser` (elastic#60423) Support Histogram Data Type (elastic#59387) [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770) [SIEM] [Cases] Update case icons (elastic#60812) [TSVB] Fix percentiles band mode (elastic#60741) Fix formatter on range aggregation (elastic#58651) Goodbye, legacy data plugin 👋 (elastic#60449) [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779) [Remote clustersadopt changes to remote info API (elastic#60795) Only run xpack siem cypress in PRs when there are siem changes (elastic#60661) ...
Summary
Adding visualize support for the Histogram type as outlined in #52426.
Histogram data type appears in the field options for the Percentiles aggregation, as well as the Percentile Ranks aggregation.
Dev tools snippets for testing:
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers