[Metrics UI] Alerting for metrics explorer and inventory #58779

phillipb · 2020-02-27T21:34:13Z

Summary

Add the alert flyout to the metric explorer and snapshot.

Metric Explorer

This PR allows creating alerts from a metrics chart, and from the header. When creating an alert from the chart, the flyout is pre-filled with conditions that correspond to the chart.

There is also the ability to create an alert per each distinct metric. For example, you can create an alert per hostname. This will allow you to create one alert for all hosts without needing to specify each exact hostname.

Inventory

On the inventory page, you can create alerts from the header and from a specific node. If you select a node, the flyout is pre-filled with a filter that targets that node. The inventory also supports the alert per functionality.

Flyout

The alert flyout uses the alerting teams AlertFlyout component. This comes with built-in actions, naming and frequency checks. We've extended it to support our need for multiple alert conditions, filtering and grouped alerts.

Fixes #56431, #56430, #56429

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

…cs-alerting

into metrics-alerting

…cs-alerting

elasticmachine · 2020-03-11T15:26:52Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

YulNaumenko

LGTM overal! But have a comment regarding toastNotifications.

x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx

YulNaumenko

LGTM! Thank you for a change about toast messages.

simianhacker · 2020-03-18T22:11:42Z

I tried to create an alert from Metrics Explorer but I keep stubbing my toe on things:

results in this error from the server

phillipb · 2020-03-19T13:24:17Z

@elasticmachine merge upstream

phillipb · 2020-03-19T16:12:06Z

I tried to create an alert from Metrics Explorer but I keep stubbing my toe on things:

Was a small type error, and is now fixed.

Zacqary · 2020-03-19T16:37:35Z

Couple issues with pre-populating the flyout. Here's what I've configured the Metrics Explorer to fetch:

When I use the Alerts dropdown in the upper-right corner of the screen, it doesn't seem to populate the flyout with anything:

I'd expect it to look more like what I get when I use the Actions dropdown next to the graph:

However, the Actions-populated alert uses both groupBy: agent.id and filtering down to a single agent.id, which is redundant. Maybe it's okay to leave it in there? Like from a UX standpoint it might be a good thing if the user just deletes the filter query, but I'm not sure.

But ultimately what I want to see is:

When I create an alert from the Alerts menu, populate the flyout with everything present in the toolbar: the aggregator, metric, groupBy, and filterQuery

Zacqary · 2020-03-19T16:40:51Z

rate and cardinality are missing from here.

Also note that when we select Document Count in the metrics explorer it removes the metric field entirely, but the alert flyout still requires us to select a metric. @simianhacker maybe we need to have a full discussion of how Document Count alerts should work? They're a stranger case than I think we originally anticipated.

Zacqary · 2020-03-19T16:43:47Z

Getting this when I graph by Rate or Cardinality and then try to create an alert through the Actions menu:

I see sum in the flyout's menu but I'm not sure if it's possible to graph by sum in the Metrics Explorer? Unless that's an alias for cardinality?

Zacqary · 2020-03-19T16:45:21Z

Can this be Select a metric instead?

Also maybe give IS ABOVE a placeholder next to it so the user knows they have to click on it to add a number

phillipb · 2020-03-19T16:45:35Z

When I use the Alerts dropdown in the upper-right corner of the screen, it doesn't seem to populate the flyout with anything:

@Zacqary When you click the alerts action menu on the top of the screen, you're outside of the context of the graph. If you want to prepopulate the alert form, you should click create alert from the chart actions menu

Zacqary · 2020-03-19T16:47:25Z

@phillipb Right but that UX doesn't make sense for creating a groupBy alert, for example. If I groupBy something that gives me 8 different graphs and I want to create an alert on all of them, I can't do that by clicking on an Actions menu.

Zacqary · 2020-03-19T16:48:52Z

I want to be able to pre-populate this (note the empty query and present groupBy param):

phillipb · 2020-03-19T16:52:49Z

I want to be able to pre-populate this (note the empty query and present groupBy param):

Hmm, I can see the utility in that. It would require a pretty big refactor to support that use though. Could be something for a follow up PR.

Zacqary · 2020-03-19T16:59:08Z

@phillipb Okay, tracking that here: #60659

…trics-alerting

…cs-alerting

simianhacker

LGTM

phillipb · 2020-03-23T12:33:52Z

@elasticmachine merge upstream

elasticmachine · 2020-03-23T12:33:54Z

merge conflict between base and head

…cs-alerting

kibanamachine · 2020-03-23T14:47:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 68b8a27

History

💚 Build #34718 succeeded 32eac0a
💛 Build #34517 was flaky 1909307
💔 Build #34361 failed 70abcc0
💔 Build #34327 failed 99c81e2
💚 Build #34071 succeeded 5b0b238

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: Fix formatter on range aggregation (elastic#58651) Goodbye, legacy data plugin 👋 (elastic#60449) [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779)

* Add flyout with expressions * Integrate frontend with backend * Extended AlertContextValue with metadata optional property * Progress * Pre-fill criteria with current page filters * Better validation. Naming for clarity * Fix types for flyout * Respect the groupby property in metric explorer * Fix lint errors * Fix text, add toast notifications * Fix tests. Make sure update handles predefined expressions * Dynamically load source from alert flyout * Remove unused import * Simplify and add group by functionality * Remove unecessary useEffect * disable exhastive deps * Remove unecessary useEffect * change language * Implement design feedback * Add alert dropdown to the header and snapshot screen * Remove icon * Remove unused props. Code cleanup * Remove unused values * Fix formatted message id * Remove create alert option for now. * Fix type issue * Add rate, card and count as aggs * Fix types Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Henry Harding <henry.harding@elastic.co>

* master: (26 commits) [Alerting] Fixes flaky test in Alert Instances Details page (elastic#60893) cleanup visualizations api (elastic#59958) Inline timezoneProvider function, remove ui/vis/lib/timezone (elastic#60475) [SIEM] Adds 'Open one signal' Cypress test (elastic#60484) [UA] Upgrade assistant migration meta data can become stale (elastic#60789) [Metrics Alerts] Remove metric field from doc count on backend (elastic#60679) [Uptime] Skip failing location test temporarily (elastic#60938) [ML] Disabling datafeed editing when job is running (elastic#60751) Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717) [SIEM] Add license check to ML Rule form (elastic#60691) Adding `authc.grantAPIKeyAsInternalUser` (elastic#60423) Support Histogram Data Type (elastic#59387) [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770) [SIEM] [Cases] Update case icons (elastic#60812) [TSVB] Fix percentiles band mode (elastic#60741) Fix formatter on range aggregation (elastic#58651) Goodbye, legacy data plugin 👋 (elastic#60449) [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779) [Remote clustersadopt changes to remote info API (elastic#60795) Only run xpack siem cypress in PRs when there are siem changes (elastic#60661) ...

…0948) * Add flyout with expressions * Integrate frontend with backend * Extended AlertContextValue with metadata optional property * Progress * Pre-fill criteria with current page filters * Better validation. Naming for clarity * Fix types for flyout * Respect the groupby property in metric explorer * Fix lint errors * Fix text, add toast notifications * Fix tests. Make sure update handles predefined expressions * Dynamically load source from alert flyout * Remove unused import * Simplify and add group by functionality * Remove unecessary useEffect * disable exhastive deps * Remove unecessary useEffect * change language * Implement design feedback * Add alert dropdown to the header and snapshot screen * Remove icon * Remove unused props. Code cleanup * Remove unused values * Fix formatted message id * Remove create alert option for now. * Fix type issue * Add rate, card and count as aggs * Fix types Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Henry Harding <henry.harding@elastic.co> Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Henry Harding <henry.harding@elastic.co>

phillipb and others added 16 commits February 24, 2020 19:20

Add flyout with expressions

4f5b456

Merge branch 'master' of https://github.com/elastic/kibana into metri…

6560cb1

…cs-alerting

Merge branch 'master' of https://github.com/elastic/kibana into metri…

22801ad

…cs-alerting

Integrate frontend with backend

f0d8b61

Merge branch 'master' of https://github.com/elastic/kibana into metri…

7adff95

…cs-alerting

Extended AlertContextValue with metadata optional property

b796ada

Merge commit 'refs/pull/59391/head' of https://github.com/elastic/kibana

a67cec8

into metrics-alerting

Progress

8c62cf9

Merge branch 'master' of https://github.com/elastic/kibana into metri…

a4f5934

…cs-alerting

Pre-fill criteria with current page filters

68fd03b

Better validation. Naming for clarity

6d5a49c

Merge branch 'master' of https://github.com/elastic/kibana into metri…

f8837a1

…cs-alerting

Fix types for flyout

e621432

Respect the groupby property in metric explorer

7956d6d

Fix lint errors

af3335c

Merge branch 'master' of https://github.com/elastic/kibana into metri…

f93bec3

…cs-alerting

phillipb marked this pull request as ready for review March 11, 2020 15:26

phillipb requested review from a team as code owners March 11, 2020 15:26

phillipb added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 v8.0.0 labels Mar 11, 2020

phillipb added the release_note:enhancement label Mar 11, 2020

phillipb changed the title ~~[DRAFT] Metrics alerting UI for metrics explorer~~ [Metrics UI] Alerting for metrics explorer Mar 11, 2020

YulNaumenko self-requested a review March 11, 2020 16:37

YulNaumenko requested changes Mar 11, 2020

View reviewed changes

x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx Outdated Show resolved Hide resolved

Fix text, add toast notifications

7dc0df9

YulNaumenko approved these changes Mar 12, 2020

View reviewed changes

Fix type issue

70abcc0

Merge branch 'master' into metrics-alerting

1909307

Zacqary mentioned this pull request Mar 19, 2020

[Metrics Alerts] Add ability to pre-populate alert from the Metrics Explorer toolbar #60659

Closed

phillipb added 3 commits March 19, 2020 16:26

Add rate, card and count as aggs

8c69617

Merge branch 'metrics-alerting' of github.com:phillipb/kibana into me…

32eac0a

…trics-alerting

Merge branch 'master' of https://github.com/elastic/kibana into metri…

38c3472

…cs-alerting

simianhacker approved these changes Mar 20, 2020

View reviewed changes

phillipb added 2 commits March 23, 2020 07:34

Merge branch 'master' of https://github.com/elastic/kibana into metri…

8b17d04

…cs-alerting

Fix types

68b8a27

phillipb merged commit a790877 into elastic:master Mar 23, 2020

phillipb mentioned this pull request Mar 23, 2020

[7.x] [Metrics UI] Alerting for metrics explorer and inventory (#58779) #60948

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Metrics UI] Alerting for metrics explorer and inventory #58779

[Metrics UI] Alerting for metrics explorer and inventory #58779

phillipb commented Feb 27, 2020 •

edited

Loading

elasticmachine commented Mar 11, 2020

YulNaumenko left a comment

YulNaumenko left a comment

simianhacker commented Mar 18, 2020

phillipb commented Mar 19, 2020

phillipb commented Mar 19, 2020

Zacqary commented Mar 19, 2020

Zacqary commented Mar 19, 2020 •

edited

Loading

Zacqary commented Mar 19, 2020

Zacqary commented Mar 19, 2020

phillipb commented Mar 19, 2020

Zacqary commented Mar 19, 2020

Zacqary commented Mar 19, 2020

phillipb commented Mar 19, 2020

Zacqary commented Mar 19, 2020

simianhacker left a comment

phillipb commented Mar 23, 2020

elasticmachine commented Mar 23, 2020

kibanamachine commented Mar 23, 2020

[Metrics UI] Alerting for metrics explorer and inventory #58779

[Metrics UI] Alerting for metrics explorer and inventory #58779

Conversation

phillipb commented Feb 27, 2020 • edited Loading

Summary

Metric Explorer

Inventory

Flyout

Checklist

elasticmachine commented Mar 11, 2020

YulNaumenko left a comment

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

simianhacker commented Mar 18, 2020

phillipb commented Mar 19, 2020

phillipb commented Mar 19, 2020

Zacqary commented Mar 19, 2020

Zacqary commented Mar 19, 2020 • edited Loading

Zacqary commented Mar 19, 2020

Zacqary commented Mar 19, 2020

phillipb commented Mar 19, 2020

Zacqary commented Mar 19, 2020

Zacqary commented Mar 19, 2020

phillipb commented Mar 19, 2020

Zacqary commented Mar 19, 2020

simianhacker left a comment

Choose a reason for hiding this comment

phillipb commented Mar 23, 2020

elasticmachine commented Mar 23, 2020

kibanamachine commented Mar 23, 2020

💚 Build Succeeded

History

phillipb commented Feb 27, 2020 •

edited

Loading

Zacqary commented Mar 19, 2020 •

edited

Loading