forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Metrics UI] Alerting for metrics explorer and inventory (elastic#58779)
* Add flyout with expressions * Integrate frontend with backend * Extended AlertContextValue with metadata optional property * Progress * Pre-fill criteria with current page filters * Better validation. Naming for clarity * Fix types for flyout * Respect the groupby property in metric explorer * Fix lint errors * Fix text, add toast notifications * Fix tests. Make sure update handles predefined expressions * Dynamically load source from alert flyout * Remove unused import * Simplify and add group by functionality * Remove unecessary useEffect * disable exhastive deps * Remove unecessary useEffect * change language * Implement design feedback * Add alert dropdown to the header and snapshot screen * Remove icon * Remove unused props. Code cleanup * Remove unused values * Fix formatted message id * Remove create alert option for now. * Fix type issue * Add rate, card and count as aggs * Fix types Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Henry Harding <henry.harding@elastic.co>
- Loading branch information
4 people
committed
Mar 23, 2020
1 parent
fbe3637
commit 99660db
Showing
15 changed files
with
887 additions
and
96 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
x-pack/plugins/infra/public/components/alerting/metrics/alert_dropdown.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import React, { useState, useCallback, useMemo } from 'react'; | ||
| import { EuiPopover, EuiButtonEmpty, EuiContextMenuItem, EuiContextMenuPanel } from '@elastic/eui'; | ||
| import { FormattedMessage } from '@kbn/i18n/react'; | ||
| import { AlertFlyout } from './alert_flyout'; | ||
| import { useKibana } from '../../../../../../../src/plugins/kibana_react/public'; | ||
|
|
||
| export const AlertDropdown = () => { | ||
| const [popoverOpen, setPopoverOpen] = useState(false); | ||
| const [flyoutVisible, setFlyoutVisible] = useState(false); | ||
| const kibana = useKibana(); | ||
|
|
||
| const closePopover = useCallback(() => { | ||
| setPopoverOpen(false); | ||
| }, [setPopoverOpen]); | ||
|
|
||
| const openPopover = useCallback(() => { | ||
| setPopoverOpen(true); | ||
| }, [setPopoverOpen]); | ||
|
|
||
| const menuItems = useMemo(() => { | ||
| return [ | ||
| <EuiContextMenuItem icon="bell" key="createLink" onClick={() => setFlyoutVisible(true)}> | ||
| <FormattedMessage | ||
| id="xpack.infra.alerting.createAlertButton" | ||
| defaultMessage="Create alert" | ||
| /> | ||
| </EuiContextMenuItem>, | ||
| <EuiContextMenuItem | ||
| icon="tableOfContents" | ||
| key="manageLink" | ||
| href={kibana.services?.application?.getUrlForApp( | ||
| 'kibana#/management/kibana/triggersActions/alerts' | ||
| )} | ||
| > | ||
| <FormattedMessage id="xpack.infra.alerting.manageAlerts" defaultMessage="Manage Alerts" /> | ||
| </EuiContextMenuItem>, | ||
| ]; | ||
| }, [kibana.services]); | ||
|
|
||
| return ( | ||
| <> | ||
| <EuiPopover | ||
| button={ | ||
| <EuiButtonEmpty iconSide={'right'} iconType={'arrowDown'} onClick={openPopover}> | ||
| <FormattedMessage id="xpack.infra.alerting.alertsButton" defaultMessage="Alerts" /> | ||
| </EuiButtonEmpty> | ||
| } | ||
| isOpen={popoverOpen} | ||
| closePopover={closePopover} | ||
| > | ||
| <EuiContextMenuPanel items={menuItems} /> | ||
| </EuiPopover> | ||
| <AlertFlyout setVisible={setFlyoutVisible} visible={flyoutVisible} /> | ||
| </> | ||
| ); | ||
| }; |
53 changes: 53 additions & 0 deletions
53
x-pack/plugins/infra/public/components/alerting/metrics/alert_flyout.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import React, { useContext } from 'react'; | ||
| import { AlertsContextProvider, AlertAdd } from '../../../../../triggers_actions_ui/public'; | ||
| import { TriggerActionsContext } from '../../../utils/triggers_actions_context'; | ||
| import { useKibana } from '../../../../../../../src/plugins/kibana_react/public'; | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| import { METRIC_THRESHOLD_ALERT_TYPE_ID } from '../../../../server/lib/alerting/metric_threshold/types'; | ||
| import { MetricsExplorerOptions } from '../../../containers/metrics_explorer/use_metrics_explorer_options'; | ||
| import { MetricsExplorerSeries } from '../../../../common/http_api/metrics_explorer'; | ||
|
|
||
| interface Props { | ||
| visible?: boolean; | ||
| options?: Partial<MetricsExplorerOptions>; | ||
| series?: MetricsExplorerSeries; | ||
| setVisible: React.Dispatch<React.SetStateAction<boolean>>; | ||
| } | ||
|
|
||
| export const AlertFlyout = (props: Props) => { | ||
| const { triggersActionsUI } = useContext(TriggerActionsContext); | ||
| const { services } = useKibana(); | ||
|
|
||
| return ( | ||
| <> | ||
| {triggersActionsUI && ( | ||
| <AlertsContextProvider | ||
| value={{ | ||
| metadata: { | ||
| currentOptions: props.options, | ||
| series: props.series, | ||
| }, | ||
| toastNotifications: services.notifications?.toasts, | ||
| http: services.http, | ||
| actionTypeRegistry: triggersActionsUI.actionTypeRegistry, | ||
| alertTypeRegistry: triggersActionsUI.alertTypeRegistry, | ||
| }} | ||
| > | ||
| <AlertAdd | ||
| addFlyoutVisible={props.visible!} | ||
| setAddFlyoutVisibility={props.setVisible} | ||
| alertTypeId={METRIC_THRESHOLD_ALERT_TYPE_ID} | ||
| canChangeTrigger={false} | ||
| consumer={'metrics'} | ||
| /> | ||
| </AlertsContextProvider> | ||
| )} | ||
| </> | ||
| ); | ||
| }; |
Oops, something went wrong.