Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes bucket span estimators loading of max_buckets setting #59639

Merged
merged 2 commits into from
Mar 9, 2020
Merged

[ML] Fixes bucket span estimators loading of max_buckets setting #59639

merged 2 commits into from
Mar 9, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Mar 9, 2020 •
edited
Loading

Fixes #59625

When the user has overridden the max_buckets setting, it no longer appears in the default section of the settings response.
This change looks in now looks in default, persistent or transient.

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 9, 2020 11:16
@jgowdyelastic jgowdyelastic self-assigned this Mar 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this fix be backported for 7.6.2 too?

walterra
walterra approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darnautov
darnautov reviewed Mar 9, 2020
View reviewed changes
x-pack/plugins/ml/server/models/bucket_span_estimator/bucket_span_estimator.js
@@ -343,11 +343,21 @@ export function estimateBucketSpanFactory(
filterPath: '*.*max_buckets',
})
.then(settings => {
if (typeof settings !== 'object' || typeof settings.defaults !== 'object') {
if (typeof settings !== 'object') {
reject('Unable to retrieve cluster settings');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add i18n for this message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we generally don't translate errors thrown from the server side, none of the other errors thrown by the bucketspan estimator are translated nor are errors in other services like the data recogniser.
This might be an oversight and we should be translating all of these, if so i would suggest we do that in a follow up PR.

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 8a4bb61 into elastic:master Mar 9, 2020
@jgowdyelastic jgowdyelastic deleted the fixing-bucket-span-estimator-loading-max_buckets branch March 9, 2020 14:43
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 9, 2020
@jgowdyelastic @elasticmachine
[ML] Fixes bucket span estimators loading of max_buckets setting (ela…
62a043c 
…stic#59639)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Mar 9, 2020
Merged
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 9, 2020
@jgowdyelastic @elasticmachine
[ML] Fixes bucket span estimators loading of max_buckets setting (ela…
4cd381b 
…stic#59639)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@pheyos pheyos mentioned this pull request Mar 9, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
0363764 
* master: (22 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'alerting/fix-flaky-instance-test' of github.com:gmmorri…
ea98883 
…s/kibana into alerting/fix-flaky-instance-test

* 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 10, 2020
jgowdyelastic added a commit that referenced this pull request Mar 10, 2020
@jgowdyelastic @elasticmachine
[7.6] [ML] Fixes bucket span estimators loading of max_buckets setting (
918cdd4 
#59639) (#59662)

* [ML] Fixes bucket span estimators loading of max_buckets setting (#59639)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* fixing test

* reverting test fix

* disabling test

* disabling tests for error text

* removing tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jgowdyelastic added a commit that referenced this pull request Mar 10, 2020
@jgowdyelastic @elasticmachine
[ML] Fixes bucket span estimators loading of max_buckets setting (#59639
e3c405b 
) (#59661)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov darnautov approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.6.2 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Estimate bucket span not working when search.max_buckets set in dynamic cluster settings
7 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @darnautov @alvarezmelissa87 @peteharverson