-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Design for Visualize #6156
New Design for Visualize #6156
Conversation
jenkins test it |
@@ -2,21 +2,179 @@ | |||
@import (reference) "~bootstrap/less/list-group"; | |||
@import (reference) "~ui/styles/list-group-menu"; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move colors out to variables, reuse kibanaGrays
ng-class="{'select-mode': finder.selector.enabled}"> | ||
|
||
<li class="list-group-item list-group-menu-item"> | ||
<ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ul inside another ul doesn't feel right. It sort of feels like you're going for a table, but I don't think we need a table here either. If you're doing this just to put the Type header there, let's just get rid of the type header. Its not an important item
@panda01 Can you also look at this, see if I missed anything? |
Yeah, I caught that. Still working on more changes. |
* @return {Array} Array sorted either ascending or descending | ||
*/ | ||
self.sortHits = function (hits) { | ||
return self.isAscending ? _.sortBy(hits, 'title') : _.sortBy(hits, 'title').reverse(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be assigning self.hits
to the result of the ternary instead of returning it.
Polished design via @alt74 for step 2. We should implement that index pattern selection as a reusable directive, paginated, selectable list. There's lots of places that could be reused. Heck, we could probably reuse it in the future to simplify the saved object loader. Should be able to borrow most/all of the saved object finder styles and code. The directive should have an isolate scope that takes 3 parameters:
The objects in the list should either require a title property, or you could make that property configurable |
There is a bug in the kbn-href directive. The pull request that corrects it is #6517. This will need to be merged into this pr. |
} | ||
} | ||
|
||
.finder-hit-count, .finder-manage-object { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this inside the saved-object-finder
above. Same with all of the .finder* classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rashidkpc, I am confused. Aren't they already under the saved-object-finder
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So they are, my bad
This LGTM now, merging |
Changes to the appearance of the visualize interface.