-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Design for Visualize #6156
Merged
Merged
New Design for Visualize #6156
Changes from 48 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
3f1c980
init changes to Visualize Page redesign
stormpython bbeb13b
Merge branch 'feature/design' of github.com:elastic/kibana into featu…
stormpython 729dbd7
adding more inline styles to break out later
stormpython b41fbee
more preliminary changes in style for the paginate element
stormpython 3c125d2
cleaning up, moving inline style to less files
stormpython c9b8d8c
updating css changes to use flexbox instead of bootstrap grid
stormpython 31c51ad
Merge branch 'feature/design' of github.com:elastic/kibana into featu…
stormpython 024835a
initial changes to step 2 process, styling and html changes to step 1
stormpython e63900a
troubleshooting styling for step 1 and step 2 visualize pages
stormpython 5af3696
adding inline styles to line up with spec
stormpython d920095
adding background color to pagination numbers
stormpython 1832f2f
adding text color to select text
stormpython ace35c3
removing inline styles
stormpython 48e8126
Merge remote-tracking branch 'upstream/feature/design' into visualize
stormpython f072adf
adding media query for step 1, adding flex to saved object finder for…
stormpython bf5d73e
minor changes
stormpython dbc9076
cleaning up css, variabilizing colors
stormpython a70c9e5
adding .empty file
stormpython 68d95b5
replacing #ffffff with @white variable
stormpython 910027a
removing dropdown menu, splitting screen on step_2 as in step_1.html,…
stormpython ee2b0b0
renaming table header, correcting link function
stormpython 1ea8f64
cleaning up
stormpython b184e08
removing unused functions that will surely break tests
stormpython 040969c
fixing issue with left column not expanding to match right column in …
stormpython 7bc5573
fixing issue with right column not matching left column on step-1
stormpython c575789
adding capitalize filter to deal with title words, tweaking padding, …
stormpython 2ba854b
replacing noun with nouns as the placeholder for text input
stormpython 735a197
finishing tests for capitalize filter, adding ability to add non-capi…
stormpython d38346c
Merge branch 'feature/design' into visualize
stormpython 73c0f9e
working on sorting
stormpython 9382b34
adding sortable hits for saved object finder
stormpython 90990f0
small refactor
stormpython f41c3a8
refactoring
stormpython 5790cb3
adding comments
stormpython b5417e9
Merge branch 'feature/design' of github.com:elastic/kibana into visua…
stormpython 2c3eccf
removing spaces
stormpython a2b92ac
Merge branch 'feature/design' of github.com:elastic/kibana into visua…
stormpython c6432bc
refactoring less
stormpython 99f4812
refactoring less files
stormpython 7af5419
refactoring less files
stormpython ba61485
refactoring less and html files
stormpython 344a444
using text-transform in favor or custom capitalize filter
stormpython cabf785
reverting a small change
stormpython ad3375e
Merge branch 'feature/design' of github.com:elastic/kibana into visua…
stormpython 6ff4e0d
changes addressing reviewer comments
stormpython aee024b
addressing reviewer comments
stormpython 18f9f78
add kbn-href
stormpython c7a412e
fixing padding
stormpython 3bfc088
lining up visualize sidebar with side nav bar as well as fixing hover…
stormpython f4ee8e3
fixing issue with url query string
stormpython File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,22 @@ | ||
<h1> | ||
Create a new visualization <br class="visible-xs"> | ||
<span class="pull-right label label-default hidden-xs">Step 1</span> | ||
<span class="label label-default visible-xs">Step 1</span> | ||
</h1> | ||
|
||
<div class="wizard-vis-types"> | ||
<a class="wizard-vis-type" | ||
ng-repeat="type in visTypes.inTitleOrder" | ||
ng-href="{{ visTypeUrl(type) }}"> | ||
<div class="wizard-vis-type-heading"> | ||
<i aria-hidden="true" class="fa fa-fw" ng-class="type.icon"></i> | ||
<h4>{{type.title}}</h4> | ||
<div class="wizard"> | ||
<div class="wizard-column"> | ||
<h3>Create New Visualization</h3> | ||
<div class="wizard-row"> | ||
<a class="wizard-type" ng-repeat="type in visTypes.inTitleOrder" ng-href="{{ visTypeUrl(type) }}"> | ||
<div class="wizard-type-heading"> | ||
<i aria-hidden="true" class="fa fa-fw" ng-class="type.icon"></i> | ||
<h4>{{type.title}}</h4> | ||
</div> | ||
<p class="wizard-type-description">{{type.description}}</p> | ||
</a> | ||
</div> | ||
<p class="wizard-vis-type-description">{{type.description}}</p> | ||
</a> | ||
</div> | ||
<div class="wizard-column"> | ||
<h3>Or, Open a Saved Visualization</h3> | ||
<saved-object-finder | ||
title="Saved Visualizations" | ||
type="visualizations" | ||
class="wizard-row"> | ||
</saved-object-finder> | ||
</div> | ||
</div> | ||
|
||
<h1>Or, open a saved visualization</h1> | ||
|
||
<saved-object-finder | ||
title="Saved Visualizations" | ||
type="visualizations"> | ||
</saved-object-finder> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,26 @@ | ||
<h1> | ||
Select a search source | ||
<span class="pull-right label label-default hidden-xs">Step 2</span> | ||
<span class="label label-default visible-xs">Step 2</span> | ||
</h1> | ||
<ul class="list-group list-group-menu" ng-switch on="stepTwoMode"> | ||
<li ng-click="stepTwoMode='new'" | ||
ng-class="{'active': stepTwoMode=='new'}" | ||
class="list-group-item list-group-menu-item"> | ||
From a new search | ||
</li> | ||
<li class="list-group-item" ng-switch-when="new"> | ||
<div class="wizard"> | ||
<div class="wizard-column"> | ||
<h3>From a New Search</h3> | ||
<!-- Index patterns --> | ||
Select an index pattern | ||
<div class="form-group"> | ||
<select | ||
class="form-control" | ||
ng-model="indexPattern.selection" | ||
ng-options="pattern as pattern for pattern in indexPattern.list | orderBy:'toString()'"> | ||
</select> | ||
<div class="wizard-row"> | ||
<div class="panel panel-default"> | ||
<div class="panel-heading">Index Patterns</div> | ||
</div> | ||
<ul class="striped list-group"> | ||
<li class="list-group-item" ng-repeat="pattern in indexPattern.list | orderBy: 'toString()'"> | ||
<a class="index-link" kbn-href="{{ makeUrl(pattern) }}">{{pattern}}</a> | ||
</li> | ||
</ul> | ||
</div> | ||
</li> | ||
|
||
<li ng-click="stepTwoMode='saved'" | ||
ng-class="{'active': stepTwoMode=='saved'}" | ||
class="list-group-item list-group-menu-item"> | ||
From a saved search | ||
</li> | ||
<li class="list-group-item" ng-switch-when="saved"> | ||
</div> | ||
<div class="wizard-column"> | ||
<h3>Or, From a Saved Search</h3> | ||
<!-- Saved searches --> | ||
<saved-object-finder | ||
title="Saved Searches" | ||
type="searches" | ||
make-url="step2WithSearchUrl"> | ||
title="Saved Searches" | ||
type="searches" | ||
class="wizard-row" | ||
make-url="step2WithSearchUrl"> | ||
</saved-object-finder> | ||
</li> | ||
</ul> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move colors out to variables, reuse
kibanaGrays