Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] E2E: install dependencies for vanilla workspaces #62178

Merged
merged 2 commits into from
Apr 2, 2020
Merged

[APM] E2E: install dependencies for vanilla workspaces #62178

merged 2 commits into from
Apr 2, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Apr 1, 2020 •
edited
Loading

Summary

  • When running e2e apm ui from scratch then it's required to run yarn before running the mock data ingestion.
$ git clone --depth 1 https://github.com/elastic/kibana
Cloning into 'kibana'...
remote: Enumerating objects: 33322, done.
remote: Counting objects: 100% (33322/33322), done.
remote: Compressing objects: 100% (27462/27462), done.
remote: Total 33322 (delta 8768), reused 20330 (delta 4595), pack-reused 0
Receiving objects: 100% (33322/33322), 334.62 MiB | 11.96 MiB/s, done.
Resolving deltas: 100% (8768/8768), done.
Checking out files: 100% (27123/27123), done.

$ cd kibana/

$ node --version
v12.10.0

$ nvm use $(cat .node-version)
Now using node v10.19.0 (npm v6.13.4)

$ ./x-pack/legacy/plugins/apm/e2e/run-e2e.sh 

To start Kibana please run the following command:
node ./scripts/kibana --no-base-path --dev --no-dev-config --config x-pack/legacy/plugins/apm/e2e/ci/kibana.e2e.yml

Temporary folder
Temporary files will be stored in: ./tmp

apm-integration-testing (logs: ./tmp/apm-it.log)
Cloning repository
Starting docker-compose

Static mock data (logs: ./tmp/ingest-data.log)
Downloading events.json...

⚠️  Not all events were ingested correctly. This might affect test tests. 


cat x-pack/legacy/plugins/apm/e2e/tmp/ingest-data.log 
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'axios'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/private/tmp/kibana/x-pack/legacy/plugins/apm/e2e/ingest-data/replay.js:32:15)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
  • On the other hand the x-pack/legacy/plugins/apm/e2e/package.json did have a dependency with the top-level package.json and therefore in order to run the ./x-pack/legacy/plugins/apm/e2e/run-e2e.sh it was required to prepare, beforehand, the kibana environment. This is not anymore the case.

@v1v v1v self-assigned this Apr 1, 2020
@v1v v1v added automation release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 1, 2020
@v1v v1v requested a review from a team April 1, 2020 15:16
@v1v v1v marked this pull request as ready for review April 1, 2020 15:16
dgieselaar
dgieselaar reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will this close #61942?

dgieselaar
dgieselaar approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will this close #61942?

@v1v
Copy link
Member Author

v1v commented Apr 2, 2020

@dgieselaar , I'm afraid it won't :( , this is to help with anyone working on a completely fresh kibana git repo.

@v1v v1v merged commit 71ff45a into elastic:master Apr 2, 2020
@v1v v1v changed the title Install e2e dependencies for vanilla workspaces [APM] E2E: install dependencies for vanilla workspaces Apr 2, 2020
@v1v v1v deleted the fix/e2e-dependencies branch April 2, 2020 13:51
@v1v v1v mentioned this pull request Apr 2, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

v1v added a commit that referenced this pull request Apr 2, 2020
@v1v
[APM] E2E: install dependencies for vanilla workspaces (#62178) (#62318)
ea53f5f
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
3eada98 
* master:
  Switch to embeddable factory interface with optional override (elastic#61165)
  fix text error in diagrams (elastic#62101)
  [Index management] Prepare support Index template V2 format (elastic#61588)
  Updates dashboard images (elastic#62011)
  [Maps] remove MapBounds type (elastic#62332)
  [Uptime] Convert anomaly Jobs name to lowercase to comply with… (elastic#62293)
  Make d3 place nicely with object values (elastic#62004)
  EMT-287: update schema with elastic agent id (elastic#62252)
  [Maps] fix replaceLayerList to handle case where map is not intialized (elastic#62202)
  Remove support for deprecated xpack.telemetry configurations (elastic#51142)
  [Uptime] Remove static constant for index name completely (elastic#62256)
  [APM] E2E: install dependencies for vanilla workspaces (elastic#62178)
  [backport] Bump to 5.1.3 (elastic#62286)
  Show server name in Remote Cluster detail panel (elastic#62250)
  Rename some alert types (elastic#61693)
  changing duration type to ms, s, m (elastic#62265)
  [ML] Clear Kibana index pattern cache on creation or form reset. (elastic#62184)
  Move `src/legacy/server/index_patterns` to data plugin (server) (Remove step) (elastic#61618)
  [NP] Remove IndexedArray usage in Schemas (elastic#61410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees

@v1v v1v

Labels
automation release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @kibanamachine @dgieselaar