Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Remove static constant for index name completely #62256

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Apr 2, 2020

Fixes #62255 . There were some remaining usages of a static defined
index name.

Checklist

Delete any items that are not applicable to this PR.

Fixes elastic#62255 . There were some remaining usages of a static defined
index name.
@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 2, 2020
@andrewvc andrewvc requested a review from shahzad31 April 2, 2020 02:38
@andrewvc andrewvc self-assigned this Apr 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, WFG !!

@shahzad31
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrewvc andrewvc merged commit 4a20567 into elastic:master Apr 2, 2020
@andrewvc andrewvc deleted the remove-static-index-name branch April 2, 2020 14:06
andrewvc added a commit to andrewvc/kibana that referenced this pull request Apr 2, 2020
)

Fixes elastic#62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
andrewvc added a commit to andrewvc/kibana that referenced this pull request Apr 2, 2020
)

Fixes elastic#62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
andrewvc added a commit that referenced this pull request Apr 2, 2020
…62323)

Fixes #62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
andrewvc added a commit that referenced this pull request Apr 2, 2020
…62322)

Fixes #62255 . There were some remaining usages of a static defined
index name.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
* master:
  Switch to embeddable factory interface with optional override (elastic#61165)
  fix text error in diagrams (elastic#62101)
  [Index management] Prepare support Index template V2 format (elastic#61588)
  Updates dashboard images (elastic#62011)
  [Maps] remove MapBounds type (elastic#62332)
  [Uptime] Convert anomaly Jobs name to lowercase to comply with… (elastic#62293)
  Make d3 place nicely with object values (elastic#62004)
  EMT-287: update schema with elastic agent id (elastic#62252)
  [Maps] fix replaceLayerList to handle case where map is not intialized (elastic#62202)
  Remove support for deprecated xpack.telemetry configurations (elastic#51142)
  [Uptime] Remove static constant for index name completely (elastic#62256)
  [APM] E2E: install dependencies for vanilla workspaces (elastic#62178)
  [backport] Bump to 5.1.3 (elastic#62286)
  Show server name in Remote Cluster detail panel (elastic#62250)
  Rename some alert types (elastic#61693)
  changing duration type to ms, s, m (elastic#62265)
  [ML] Clear Kibana index pattern cache on creation or form reset. (elastic#62184)
  Move `src/legacy/server/index_patterns` to data plugin (server) (Remove step) (elastic#61618)
  [NP] Remove IndexedArray usage in Schemas (elastic#61410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Remove remaining INDEX_NAME constants
4 participants