Adds link for Cloud deployment settings #66486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
force-pushed
the
cloud-deployment-link
branch
2 times, most recently
from
d016513
to
dc53e8c
Compare
pgayvallet
reviewed
May 15, 2020
|
Ping @elastic/kibana-core-ui for review on header components |
cqliu1
changed the title
cqliu1
force-pushed
the
cloud-deployment-link
branch
from
dc53e8c
to
34824f9
Compare
mshustov
reviewed
May 17, 2020
| /** | ||
| * Override the current set of custom nav link | ||
| */ | ||
| setCustomLink(newCustomLink?: ChromeCustomLink): void; |
There was a problem hiding this comment.
Why not more extendable version:Chrome CustomLink[]?
There was a problem hiding this comment.
After discussing with @ryankeairns, we didn't want to allow for multiple links to be registered by plugins and potentially flood the left nav. This is also a temporary addition to the collapsible nav to provide cloud users a link that redirects them to the cloud console and should really only be used by the cloud plugin until the redesign work in #65787 relocates this link.
|
Catherine and I just talked over slack and came up with a plan to move away from using a new
Reusing @elastic/kibana-platform Shout out if this doesn't seem right to y'all and if you'd prefer to see a new type added for this after all. |
|
@myasonik As long as this doesn't mean introducing additional fields to |
cqliu1
force-pushed
the
cloud-deployment-link
branch
from
34824f9
to
834d03c
Compare
|
@cqliu1 similar to the Cloud profile links PR, can you provide a snippet for the |
@ryankeairns Sure! All you need to do is a define a cloud ID and a deployment url in your kibana.dev.yml like this: |
|
The UI design looks good; sample config works as expected. |
Accesses deploymentUrl config property Added i18n support for deployment link Resolved merge conflict Use existing ChromeNavLink type Added external link option to createNavLink
cqliu1
force-pushed
the
cloud-deployment-link
branch
from
7d2a068
to
33fa8fb
Compare
cqliu1
added
enhancement
myasonik
approved these changes
Jun 3, 2020
Co-authored-by: Michail Yasonik <michail@yasonik.com>
… cloud-deployment-link
ryankeairns
approved these changes
Jun 4, 2020
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Jun 8, 2020
Comment on lines
73
to
+74
| if ( | ||
| !externalLink && // ignore external links |
There was a problem hiding this comment.
NIT: by using the new navigateToUrl API instead of navigateToApp, we could get rid of this additional check and externalLink parameter. But platform can do it later.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Jun 25, 2020
Co-authored-by: Michail Yasonik <michail@yasonik.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #65089.
Related to https://github.com/elastic/cloud/issues/57690.
This adds a link to the Cloud deployment page to the left nav when the cloud plugin is enabled, i.e Kibana is running on cloud. This link will show for all Kibana users on cloud, but only cloud users that authenticate with admin privileges to their cloud deployment will be able to access the cloud deployment page.
Note: This is a temporary solution for redirecting Cloud users from Kibana back to the Cloud console. This component will be removed in favor of the redesign work described in #65787.
To test
You can mock enabling the cloud plugin locally by defining a cloud ID and deployment url in your
kibana.dev.yml, like so:Checklist
Delete any items that are not applicable to this PR.
For maintainers