chore(NA): setup config folder with env var on fpm os packages #67433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
pgayvallet
approved these changes
May 27, 2020
6 tasks
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@jbudz had you the chance to test that approach both for |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
May 29, 2020
|
Thanks @jbudz ! I'll do this in another PR |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
May 30, 2020
…th fpm (elastic#67433) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
May 30, 2020
…th fpm (elastic#67433) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Jun 30, 2021
When `(KBN|KIBANA)_PATH_CONF` was introduced, we removed the fallback lookup to `/etc/kibana/kibana.yml` in elastic#67433. This environment variable was added to `/etc/default/kibana` and made available, scoped to the Kibana service for deb and rpm packages. This environment setting, however, is not available when running binaries directly and caused the regression noted in This re-adds a fallback lookup to `/etc/kibana/kibana.yml` when searching for a kibana.yml configuration. Testing 1) Install a .deb or .rpm package 2) `sudo -u kibana /usr/share/bin/kibana --version` Closes elastic#101249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That pr setup the ENV var
KIBANA_PATH_CONFin order to have it pointing to the correct location of the config path. That has been discussed on #62468 and it is required for that PR.@jbudz could you help me making sure it works as we expected? From what I was able to test what I'm doing here would do what we want.