Node options from cfg file for production #62468

mistic · 2020-04-03T15:43:16Z

Closes #61845

That PR is an idea to enable the ability to load node options from a configuration file.

The basic outline for this feature is:

config/node.options is used for the distributable environments.

Blocked by:

Move bin scripts into the build chore(NA): move bin scripts into build #67568
Setup KIBANA_PATH_CONF to point to /etc/kibana on os_packages built with fpm chore(NA): setup config folder with env var on fpm os packages #67433
Remove "-c /etc/config/kibana.yml" from /etc/system.d/system/kibana.service chore(NA): remove config arg from os packages #67871

TODO:

Create kbn-node bin script that reads from config/node.dev.options if provided and fallback to config/node.ci.options otherwise. It is installed on bootstrap.
Remove scripts/run_with_node_options and the underlying CLI
Refactor package.json node scripts/.. to use kbn-node scripts/.. instead

… fil

…-cfg-file

elasticmachine · 2020-04-03T15:43:18Z

Pinging @elastic/kibana-operations (Team:Operations)

…-cfg-file

mistic · 2020-04-06T09:23:07Z

@elasticmachine merge upstream

mistic · 2020-04-06T14:10:53Z

@elasticmachine merge upstream

mistic · 2020-04-09T23:55:05Z

@elasticmachine merge upstream

tylersmalley

LGTM

mistic · 2020-07-01T12:34:35Z

@elasticmachine merge upstream

mistic · 2020-07-02T03:50:35Z

@elasticmachine merge upstream

mistic · 2020-07-03T01:01:32Z

@elasticmachine merge upstream

mistic · 2020-07-05T22:28:11Z

@elasticmachine merge upstream

mistic · 2020-07-06T00:06:31Z

@elasticmachine merge upstream

mistic · 2020-07-06T15:46:15Z

@elasticmachine merge upstream

mistic · 2020-07-08T16:10:11Z

@elasticmachine merge upstream

mistic · 2020-07-09T18:29:51Z

@elasticmachine merge upstream

mistic · 2020-07-13T12:56:01Z

@elasticmachine merge upstream

kibanamachine · 2020-07-13T14:40:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 27b9dc0

Build metrics

✅ unchanged

History

💚 Build #60383 succeeded 5e0c586
💛 Build #59819 was flaky a7d4a46
💚 Build #59027 succeeded 72244dd
💔 Build #58788 failed 6027f49
💔 Build #58782 failed 00b04dc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic · 2020-07-13T15:30:36Z

7.x: bf08e8a

* chore(NA): load NODE_OPTIONS from options files across environments * chore(NA): move node.ci.options to config folder * docs(NA): update docs to explain how to set node options from the cfg fil * chore(NA): removed test npm scripts * fix(NA): typo on setup script for CI * chore(NA): add debug info * chore(NA): export options on CI * chore(NA): remove debug info * chore(NA): support for configurable config folder using env var * chore(NA): add node.options file into docker img * fix(NA): use calculated config dir on node options for ci * chore(NA): node bin scripts bootstrap and node_with_options implementation for bash * chore(NA): complete node_with_options scripts with bat version * chore(NA): add bin/node dev script and remove cli for run_with_node_options * chore(NA): increase default maxBuffer * chore(NA): remove run with options script from package.json * chore(NA): include kbn-node script and underlying usage of it * chore(NA): remove change on eslint * chore(NA): correct typo on kbn node script comment Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): correct typo on kbn node script comment Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): add line to describe each option should be specified in a separated line * chore(NA): remove node options from dev and ci env * chore(NA): remove changes from package.json * chore(NA): fix docker image build * chore(NA): change value for example of --max-old-space-size in the node.options file Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): remove --no-warnings from node.options and force it in the bin scripts * chore(NA): prevent 'The system cannot find the file' error message * chore(NA): introduce slash when building path for %DIR% * chore(NA): read options from file only if it exists Co-authored-by: Jonathan Budzenski <jbudz@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Tyler Smalley <tylersmalley@me.com>

* master: (28 commits) skip flaky suite (elastic#71361) [Ingest Manager] Add UI to enroll standalone agent (elastic#71288) Node options from cfg file for production (elastic#62468) [APM] Improvements to the ML Settings page (elastic#71309) add old .chromium to gitignore to prevent it from being accidentally committed [Ingest Manager] Simplify add/edit package config (integration) form (elastic#71187) Ensure Other bucket works on scripted fields. (elastic#71329) [APM] Anomaly detection setup link with alert if job doesn't exist (elastic#71229) [APM] Anomaly detection integration with transaction duration chart (elastic#71230) inclusive language (elastic#71438) [Ingest Manager] During fleet setup create an enrollment for every config (elastic#71308) Improvements to our developer guide (elastic#67764) [SIEM][Detections] Fixes index patterns order (elastic#71270) [Metrics + Logs UI] Add test for logs and metrics telemetry (elastic#70858) [Maps] Inclusive language (elastic#71427) [Logs UI] Unskip log highlight api integration test (elastic#71058) [Security_Solution][Resolver] Style adjustments per UX (elastic#71179) [Functional test] Increase the timeout to click new vis function (elastic#71226) [Discover] Migrate async import of embeddable factory to actual embeddable (elastic#70920) fix overflow (elastic#70723) ...

* chore(NA): load NODE_OPTIONS from options files across environments * chore(NA): move node.ci.options to config folder * docs(NA): update docs to explain how to set node options from the cfg fil * chore(NA): removed test npm scripts * fix(NA): typo on setup script for CI * chore(NA): add debug info * chore(NA): export options on CI * chore(NA): remove debug info * chore(NA): support for configurable config folder using env var * chore(NA): add node.options file into docker img * fix(NA): use calculated config dir on node options for ci * chore(NA): node bin scripts bootstrap and node_with_options implementation for bash * chore(NA): complete node_with_options scripts with bat version * chore(NA): add bin/node dev script and remove cli for run_with_node_options * chore(NA): increase default maxBuffer * chore(NA): remove run with options script from package.json * chore(NA): include kbn-node script and underlying usage of it * chore(NA): remove change on eslint * chore(NA): correct typo on kbn node script comment Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): correct typo on kbn node script comment Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): add line to describe each option should be specified in a separated line * chore(NA): remove node options from dev and ci env * chore(NA): remove changes from package.json * chore(NA): fix docker image build * chore(NA): change value for example of --max-old-space-size in the node.options file Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): remove --no-warnings from node.options and force it in the bin scripts * chore(NA): prevent 'The system cannot find the file' error message * chore(NA): introduce slash when building path for %DIR% * chore(NA): read options from file only if it exists Co-authored-by: Jonathan Budzenski <jbudz@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Tyler Smalley <tylersmalley@me.com> Co-authored-by: Jonathan Budzenski <jbudz@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Tyler Smalley <tylersmalley@me.com>

jbudz and others added 7 commits March 19, 2020 02:36

chore(NA): load NODE_OPTIONS from options files across environments

8dfa276

chore(NA): move node.ci.options to config folder

76cde2e

Merge branch 'master' into node-options-from-cfg-file

7b7c98e

Merge branch 'master' into node-options-from-cfg-file

ff02155

docs(NA): update docs to explain how to set node options from the cfg…

09764ca

… fil

chore(NA): removed test npm scripts

fd04141

Merge remote-tracking branch 'upstream/master' into node-options-from…

7b74c3e

…-cfg-file

mistic added release_note:enhancement Team:Operations Team label for Operations Team v8.0.0 Feature:Configuration Settings in kibana.yml v7.8.0 labels Apr 3, 2020

mistic requested a review from a team as a code owner April 3, 2020 15:43

mistic added 2 commits April 3, 2020 17:15

Merge remote-tracking branch 'upstream/master' into node-options-from…

fbed0eb

…-cfg-file

fix(NA): typo on setup script for CI

3a2382b

mistic requested review from jbudz and tylersmalley April 3, 2020 16:45

mistic added 4 commits April 3, 2020 19:36

Merge remote-tracking branch 'upstream/master' into node-options-from…

b59eb08

…-cfg-file

chore(NA): add debug info

f551fd8

chore(NA): export options on CI

00c9bad

chore(NA): remove debug info

ed3f6fa

Merge branch 'master' into node-options-from-cfg-file

305a7f6

Merge branch 'master' into node-options-from-cfg-file

891eda5

mistic force-pushed the node-options-from-cfg-file branch from 2ee0ecd to 891eda5 Compare April 7, 2020 18:27

Merge branch 'master' into node-options-from-cfg-file

7b529a2

Merge branch 'master' into node-options-from-cfg-file

20ac1e2

elasticmachine and others added 2 commits June 28, 2020 17:17

Merge branch 'master' into node-options-from-cfg-file

1a2f1b9

chore(NA): read options from file only if it exists

a3b0f06

tylersmalley approved these changes Jun 30, 2020

View reviewed changes

Merge branch 'master' into node-options-from-cfg-file

8f79338

Merge branch 'master' into node-options-from-cfg-file

d6fbb4b

jbudz approved these changes Jul 2, 2020

View reviewed changes

Merge branch 'master' into node-options-from-cfg-file

d7630bc

Merge branch 'master' into node-options-from-cfg-file

00b04dc

Merge branch 'master' into node-options-from-cfg-file

6027f49

Merge branch 'master' into node-options-from-cfg-file

72244dd

Merge branch 'master' into node-options-from-cfg-file

a7d4a46

Merge branch 'master' into node-options-from-cfg-file

5e0c586

Merge branch 'master' into node-options-from-cfg-file

27b9dc0

mistic merged commit 24edc80 into elastic:master Jul 13, 2020

mistic mentioned this pull request Jul 13, 2020

[7.x] Node options from cfg file for production (#62468) #71463

Merged

tylersmalley mentioned this pull request Jul 22, 2020

Not able to set NODE_OPTIONS in sysconfig for systemd environment #36671

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node options from cfg file for production #62468

Node options from cfg file for production #62468

mistic commented Apr 3, 2020 •

edited

Loading

elasticmachine commented Apr 3, 2020

mistic commented Apr 6, 2020

mistic commented Apr 6, 2020

mistic commented Apr 9, 2020

tylersmalley left a comment

mistic commented Jul 1, 2020

mistic commented Jul 2, 2020

mistic commented Jul 3, 2020

mistic commented Jul 5, 2020

mistic commented Jul 6, 2020

mistic commented Jul 6, 2020

mistic commented Jul 8, 2020

mistic commented Jul 9, 2020

mistic commented Jul 13, 2020

kibanamachine commented Jul 13, 2020

mistic commented Jul 13, 2020 •

edited

Loading

Node options from cfg file for production #62468

Node options from cfg file for production #62468

Conversation

mistic commented Apr 3, 2020 • edited Loading

elasticmachine commented Apr 3, 2020

mistic commented Apr 6, 2020

mistic commented Apr 6, 2020

mistic commented Apr 9, 2020

tylersmalley left a comment

Choose a reason for hiding this comment

mistic commented Jul 1, 2020

mistic commented Jul 2, 2020

mistic commented Jul 3, 2020

mistic commented Jul 5, 2020

mistic commented Jul 6, 2020

mistic commented Jul 6, 2020

mistic commented Jul 8, 2020

mistic commented Jul 9, 2020

mistic commented Jul 13, 2020

kibanamachine commented Jul 13, 2020

💚 Build Succeeded

Build metrics

History

mistic commented Jul 13, 2020 • edited Loading

mistic commented Apr 3, 2020 •

edited

Loading

mistic commented Jul 13, 2020 •

edited

Loading